MESMER-group / mesmer

spatially-resolved ESM-specific multi-scenario initial-condition ensemble emulator
https://mesmer-emulator.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 15 forks source link

change optimize.minimize method from SLSQP to Nelder-Mead #455

Closed veni-vidi-vici-dormivi closed 1 month ago

veni-vidi-vici-dormivi commented 1 month ago

Changing the method in optimize.minimize` to Nelder-Mead from SLSQP should make the coefficients fit more stable, see https://github.com/MESMER-group/mesmer/issues/440#issuecomment-2127172434

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.19%. Comparing base (9b0b76b) to head (ff8f733). Report is 46 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #455 +/- ## ========================================== - Coverage 87.90% 82.19% -5.72% ========================================== Files 40 43 +3 Lines 1745 1938 +193 ========================================== + Hits 1534 1593 +59 - Misses 211 345 +134 ``` | [Flag](https://app.codecov.io/gh/MESMER-group/mesmer/pull/455/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/MESMER-group/mesmer/pull/455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | `82.19% <ø> (-5.72%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.