Internal classes blocking extendability

MFlisar / ComposePreferences

Compose Preference Screen for Android - Material3 Design (including customisation, nesting and more)

Apache License 2.0

8 stars 0 forks source link

Internal classes blocking extendability #4

Closed jscti closed 8 months ago

jscti commented 8 months ago

Me again :)

Would it be possible to have access to some of your internal ProvidableCompositionLocal to increase extendability ?

For example, I want to create a custom preference like on Android system settings :

left zone (text) would open a PreferenceSubScreen
righ zone (IconButton) would be any PreferenceWidget (checkbox in my case)

But when trying to adapt PreferenceSubScreen, I got stuck due to internal restrictions :

Thanks

jscti commented 8 months ago

In the end I don't use PreferenceSubScreen but I created a sub screen that I handle with my app navController like any other screen. No limitation that way (appBar etc)

Feel free to close this issue if needed

MFlisar commented 8 months ago

In this case I'd say it would make sense to add this feature optionally to the existing PreferenceSubScreen. It does not make sense to expose the internal hierarchy management as it would allow to destroy the libraries functionality if used wrongly...

For now I close that, feel free to add that as a pull request if you want to.