search

MFlisar / GDPRDialog

GDPR fragment dialog implementation
Apache License 2.0
211 stars 53 forks source link

Admob and consent SDK. #27

Closed SoftNirav closed 6 years ago

SoftNirav commented 6 years ago

In the readme there is no clarity if the Consent SDK provided by Google should be used with this GDPR Dialog. Or the consent should be sent directly to PublisherAdRequest of Google Mobile Ads SDK. Is this project meant to replace Consent SDK or is a 'Publisher-managed consent collection' utility. I also don't understand how GDPR Dialog obtains EEA location data.

MFlisar commented 6 years ago

I use the same urls to query Google's data and just interpreted the json response myself. This way I do the same as the sdk to retrieve your admob ad networks and your location

This is a replacement and the consent retrieved via this library should be manually passed to your ad request

SoftNirav commented 6 years ago

Thanks a lot. I was a bit worried as I am going to use this in a production release. I want the list of 600+ sub networks and Google's consent utility supports just 12. Release 1.0 of GDPR Dialog dosen't support withLoadAdMobNetworks(publisherId(s)) and it's a requirement as per GDPR AFAIK. I hope using the master build will not have issues though.

MFlisar commented 6 years ago

I'll make a release in the evening. Feel free to test it though in the meantime...

600 networks? I think Google will only select 200 for you if you have not selected any yourself... at least the sdk url returns 200 in this case...

SoftNirav commented 6 years ago

Oh thanks! Google is showing only 200 providers in 'Commonly used set of ad technology providers'. I can't wait till the evening there as it's gonna going to be night here!

MFlisar commented 6 years ago

How do you want to create the most of 600+ networks? Manually? The sdk does not return more than the commonly used ones...

MFlisar commented 6 years ago

Issue is solved I think, so I close it