MFlisar / GDPRDialog

GDPR fragment dialog implementation
Apache License 2.0
211 stars 53 forks source link

Please make consent states clear #39

Closed SoftNirav closed 6 years ago

SoftNirav commented 6 years ago

Will the callback ever return UNKNOWN or NO_CONSENT GDPRConsent states? What can be done if it returns that? I was confused separating stuff in the callback, when I came across this: https://github.com/MFlisar/GDPRDialog/blob/master/library/src/main/java/com/michaelflisar/gdprdialog/GDPRConsent.java

And is there anyway with which it can be immediately decided whether to show or not the 'Withdraw consent' button in the onCreate of a settingsActivity? If the user has not been shown the dialog box ever in the past due to being outside EEA, he shan't be shown the button.

MFlisar commented 6 years ago

Which comment is not clear?

UNKNOWN... that's the state as long as the user (or the library) has not made any decision NO_CONSENT... the user does not want personal data usage nor non personal data usage...

SoftNirav commented 6 years ago

The question is: Will any of the above two consent states be returned in the onConsentInfoUpdate() callback? If yes, what is expected to be done in the callback? Don't show ads? Atleast Non-Personal consent is required to show ads.

NO_CONSENT... the user does not want personal data usage nor non personal data usage

Should the app not close if the user denies non personal data!

MFlisar commented 6 years ago

UNKNOWN will never occur in onConsentInfoUpdate. And interpretation of NO_CONSENT is up to the setup. It's up to you to allow app usage without consent or the user may expect to be shown the buy app dialog, depending on the setup...