search

MFlisar / GDPRDialog

GDPR fragment dialog implementation
Apache License 2.0
211 stars 53 forks source link

Title of message - free / cheap related text #56

Closed Terence-D closed 6 years ago

Terence-D commented 6 years ago

For my application I'm only using crashalytics / analytics, this is both in the free and paid versions (and both are optional). The current title will imply the app is free or cheap because of this, but if i set it to Paid which allows it to say cheap for my paid apps, it automatically inserts a button to go to the paid version - which I don't want. If I don't include that it says free, when the app may not have been free.

I can't alter the text because because it expects to insert free or cheap via getString.

I modified my own version to just remove that part of the title so it now only has the first sentence: Original:

We care about your privacy and data security. We keep this app %1$s by using third party services.

My version:

We care about your privacy and data security.

Is there some way to make the second sentence optional?

MFlisar commented 6 years ago

I checked the translations and every language is seperating the two sentences, so this is easy...

Checkout the new withShowPaidOrFreeInfoText function in the master branch:

https://github.com/MFlisar/GDPRDialog/blob/e4782415c61bd0a2326dc3fc0313ac0ac959eaa4/library/src/main/java/com/michaelflisar/gdprdialog/GDPRSetup.java#L217