search

MFlisar / GDPRDialog

GDPR fragment dialog implementation
Apache License 2.0
211 stars 53 forks source link

Can't Disable Certain Properties #64

Closed vedantroy closed 5 years ago

vedantroy commented 6 years ago

I have the following setup object in my onCreate method:

        GDPR.getInstance().init(this)
        setup = GDPRSetup(GDPRDefinitions.FIREBASE_CRASH)
                .withShowPaidOrFreeInfoText(false)
                .withExplicitAgeConfirmation(false)
                .withShortQuestion(false)

I later show the dialog like this when a button is clicked:

GDPR.getInstance().showDialog(this, setup, GDPRLocation.UNDEFINED)

However, the "Can we continue to use your data for these purposes?" and "By agreeing, you are confirming that you are over the age of 16." messages are still showing.

robigangsta commented 6 years ago

Agree, the customization seemed great but at the deeper look it turns out to be horrible. You should allow users to change text because you can't have one text for all apps. It just doesn't fit.

Also there seems to be no way to disable option to buy the app, my app doesn't have paid version. Smh and I had such high hopes for this lib

vedantroy commented 6 years ago

@robigangsta I think it may just be a big in the library. Afterall, the API suggests it is possible to disable various elements.

MFlisar commented 6 years ago

You can always overwrite ANY resource in your app, android offers this out of the box.

I would not mind if someone implements withMainText(String), withAgeText(String) and similar to customise the texts via the builder as well...

MFlisar commented 5 years ago

Newest version allows to overwrite all texts of the main view:

https://github.com/MFlisar/GDPRDialog/blob/ed2f8655040147bf2ee553b22ece5f1e02e95a6e/app/src/main/java/com/michaelflisar/gdprdialog/demo/SetupActivity.java#L169-L187