search

MFlisar / GDPRDialog

GDPR fragment dialog implementation
Apache License 2.0
211 stars 53 forks source link

Bugfixes, UI Improvements #89

Closed 1951FDG closed 4 years ago

1951FDG commented 5 years ago

Thanks for this great library, I spent the last two days troubleshooting an issue, which finally led me to the discovery of a double negative, I also added a couple of accessibility and styling improvements, the commits speak for themselves, if you have any questions let me know.

One tip which could be added to README:

To make the dialog width equal to that of an alert dialog, the following theme can be used: .withCustomDialogTheme(R.style.ThemeOverlay_MaterialComponents_Dialog_Alert)

1951FDG commented 4 years ago

Hi there, I haven't heard back from you, have you had a chance to look at my pull request?

MFlisar commented 4 years ago

Thanks for the contribution and sorry for the late reply and merge. Release v1.4.2 does contain your changes, thanks

1951FDG commented 4 years ago

Thank you!!

Another tip which could be added to README:

I am using a base theme which has windowNoTitle set to true, to avoid setting withNoToolbarTheme(true) which would add a toolbar (most likely with a colored background), the following theme can be used to display dialog title:

.withCustomDialogTheme(R.style.ThemeOverlay_MaterialComponents_Dialog_Alert_Custom)
<style name="ThemeOverlay.MaterialComponents.Dialog.Alert.Custom" parent="ThemeOverlay.MaterialComponents.Dialog.Alert">
        <item name="windowNoTitle">false</item>
</style>