MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
144 stars 67 forks source link

No documentation for how to use cylindrical and axisymmetric coordinates #278

Closed wilfonba closed 18 hours ago

wilfonba commented 10 months ago

There is no documentation on how to run simulations using cylindrical and axisymmetric coordinates. There are several intricacies to using cylindrical coordinates (and I assume axisymmetric coordinates) that I've come across when trying to run a 3D pipe flow. Perhaps an additional appendix to the case file documentation would best alleviate this? This isn't a commonly used feature, but it should be documented nonetheless. There should probably be an appendix in the flow visualization documentation detailing how to perform the coordinate transformations correctly as well as it's not as obvious as one might think.

sbryngelson commented 5 months ago

Is this still open or no @wilfonba ?

wilfonba commented 5 months ago

Still open

sbryngelson commented 3 months ago

@ChrisZYJ I cannot remember if you added documentation for this or not. Can you remind me?

ChrisZYJ commented 3 months ago

@sbryngelson I fixed 2D axisymmetric and added detailed documentation for it. For the 3D cylindrical coordinates, I wasn't able to get it working (its previous implementation was actually for 2D axisymmetric), so I removed it from the documentation. I intentionally left a few gaps in the Acoustic Supports label numbering to allow for future additions if someone manages to fix the 3D cylindrical coordinates implementation.

sbryngelson commented 3 months ago

@ChrisZYJ I meant for 3D cylindrical coordinates without any acoustic source. These should work; they just aren't documented. I thought maybe you added documentation for them.

ChrisZYJ commented 3 months ago

Sorry I didn't read the thread properly. No, I didn't manage to get it working. Was also wondering where the documentation is