MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
145 stars 67 forks source link

Creates NCSA Delta modules and mako templates for batch jobs #338

Closed sbryngelson closed 8 months ago

sbryngelson commented 8 months ago

Description

Creates NCSA Delta modules and mako templates for batch jobs

Type of change

Please delete options that are not relevant.

Scope

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist

If your code changes any code source files (anything in src/)

To make sure the code is performing as expected on GPU devices, I have:

henryleberre commented 8 months ago

@sbryngelson, does this template also work for interactive jobs? i.e. are you able to run the test suite on an allocated node with ./mfc.sh test -- -c delta ?

sbryngelson commented 8 months ago

@sbryngelson, does this template also work for interactive jobs? i.e. are you able to run the test suite on an allocated node with ./mfc.sh test -- -c delta ?

It works if you first salloc yourself resources, which I assume is the intended use case?

henryleberre commented 8 months ago

@sbryngelson, does this template also work for interactive jobs? i.e. are you able to run the test suite on an allocated node with ./mfc.sh test -- -c delta ?

It works if you first salloc yourself resources, which I assume is the intended use case?

Yes! I was just checking since srun does not always work interactively.

sbryngelson commented 8 months ago

Update: It actually didn't work with srun in interactive mode. I just didn't notice the change I made. Updating now.