RHS Refactor 2 - Githubissues

MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics

https://mflowcode.github.io

MIT License

137 stars 60 forks source link

RHS Refactor 2 #356

Closed wilfonba closed 5 months ago

wilfonba commented 5 months ago

Description

Leaves the advection source term in m_compute_rhs so that the code works with Intel compilers.

Fixes #(issue) [optional]

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Scope

[x] This PR comprises a set of related changes with a common goal

How Has This Been Tested?

This is a branch made from a commit that passed CI in the past.

What computers and compilers did you use to test this: Phoenix, Github runners

Checklist

[x] I have added comments for the new code
[x] I ran ./mfc.sh format before committing my code
[x] New and existing tests pass locally with my changes, including with GPU capability enabled and disabled
[x] I cannot think of a way to condense this code and reduce any introduced additional line count