Closed wilfonba closed 1 month ago
@wilfonba check s_rectangle subroutine in m_patches.fpp, it only defines smooth_patch_id when ib is not true (lines 893-894), and you added a further check at line 928 where that variable is no longer defined, which is causing a bug in the 3D IBM case
I forgot I'd added that stuff. Thanks for taking a look @anandrdbz!
PRs are on hold until #419 is fixed
add more example cases in examples/
!
PRs are on hold until #419 is fixed
I'm aware of this. I figured starting the review process wouldn't hurt anything so that I can fix any revisions while that issue is being resolved.
per This PR comprises a set of related changes with a common goal
please move the template updates to a separate PR
@wilfonba sync w/ master
should be able to debug these Test Suite / Github (macos, mpi, debug, false) (pull_request)
from your own mac
Note: ./mfc.sh count_diff
is called from master
so the Check Line Counts
workflow is expected to fail despite the fixes I pushed to this PR.
Let me fix the macOS no debug runners. Not sure why those would have failed, but I haven't ran the test suite with no debug recently
Let me fix the macOS no debug runners. Not sure why those would have failed, but I haven't ran the test suite with no debug recently
Related to new issue #443
Can merge this PR without that runner working
Description
This PR adds the surface tension model of Schmidmayer et. al 2017 to MFC.
Fixes #276
Type of change
Scope
How Has This Been Tested?
x[y]_beg
and ghost cell extrapolation forx[y]_end
. The case file is available inexamples/2D_equilibration/
. This simulation was run on M2 Apple Silicone.https://github.com/MFlowCode/MFC/assets/48168887/12fed2fe-ae11-4b81-bc4f-51104150a1b7
x[y]_beg
and ghost cell extrapolation forx[y]_end
. The case file is available inexamples/2D_recoverCircle
. This simulation was run on 2 V100 GPUs.https://github.com/MFlowCode/MFC/assets/48168887/4ab34fa0-12ae-40f2-a507-b56517e15984
x[y,z]_beg
and ghost cell extrapolation atx[yz]_end
. This simulation was ran using 4 V100 GPUs on Pace Phoenix.https://github.com/MFlowCode/MFC/assets/48168887/e1b8280d-3630-49da-af75-7eeb893b678c
x[y,z]_beg
and ghost cell extrapolation atx[yz]_end
. This simulation was ran using 8 MI250 GPUs on OLCF Frontier. While equilibration is not reached, the relaxation shown is the asymmetric and the expected behavior. One octant of the cube is simulated and reflections used for visualization. This case is given as an example inexamples/3D_surface_tension
.https://github.com/MFlowCode/MFC/assets/48168887/ad810648-113d-4a8a-8b05-354f4876f49b
Checklist
docs/
)examples/
that demonstrate my new feature performing as expected./mfc.sh format
before committing my codeIf your code changes any code source files (anything in
src/
)To make sure the code is performing as expected on GPU devices, I have:
nvtx
ranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys
, and have attached the output file (.nsys-rep
) and plain text results to this PR nsysRaw.txtexamples/3D_weak_scaling
with 32GB per GPU with 8 MI250 GPUs on both the master branch and this fork with the following time/time-step: Master: 0.555s This Fork: 0.539s I'm not sure why this fork is faster, but these results were consistent across three runs.