Closed sbryngelson closed 1 month ago
Is there a reason why these are integer values and not float ?
@anandrdbz out of convenience, I suppose. Please see this issue for a possible fix https://github.com/MFlowCode/MFC/issues/393
@anandrdbz After watching the last PR fail a few times here https://github.com/MFlowCode/MFC/actions/runs/8638692906/job/23683596528?pr=285
I'm not really sure why there's a divide-by-zero problem or what is happening. It seems like one of the tests failed (either PR or master), but it isn't reporting that. @henryleberre any idea what's going on? Could look into the logs for this as well...
Update: In that PR i think it's because something in the PR is causing all of the cases to output 0 (likely the code @anandrdbz put in the .mako
file). I suspect this is the problem whenever we see a divide by zero error.. a case either didn't run or there's a bug in printing its length.
Fixed by #423
I'm not sure why it happens but we have an issue where we sometimes get a divide by zero in benchmark diff (e.g., https://github.com/MFlowCode/MFC/actions/runs/8610942830/job/23597260867?pr=285):
Part of the fix is a proper Python exception if either the
lhs_summary[target.name]
orrhs_summary[target.name
is zero.