MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
132 stars 56 forks source link

Update on adaptive time stepping for sub-grid bubbles #408

Open lee-hyeoksu opened 1 month ago

lee-hyeoksu commented 1 month ago

Description

This PR includes some updates on adaptive time stepping for sub-grid bubbles to improve the accuracy of the scheme. Also, I tried to make the subroutine s_compute_bubble_source be more concise by modularizing some parts into a few separate subroutines.

This PR basically does not fix any bug nor introduce new features.

Type of change

Please delete options that are not relevant.

Scope

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes missing coverage. Please review.

Project coverage is 57.95%. Comparing base (2810b09) to head (5e41432).

Files Patch % Lines
src/simulation/m_bubbles.fpp 85.10% 3 Missing and 4 partials :warning:
src/simulation/m_time_steppers.fpp 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #408 +/- ## ========================================== + Coverage 57.91% 57.95% +0.03% ========================================== Files 55 55 Lines 14230 14241 +11 Branches 1854 1854 ========================================== + Hits 8242 8254 +12 Misses 5452 5452 + Partials 536 535 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.