-1.2k LOC in s_mpi_sendrecv_variables_buffers

MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics

https://mflowcode.github.io

MIT License

132 stars 56 forks source link

-1.2k LOC in s_mpi_sendrecv_variables_buffers #409

Closed henryleberre closed 1 month ago

henryleberre commented 1 month ago

Description

s_mpi_sendrecv_variables_buffers has too much repetition and is therefore very hard to read and maintain. This PR refactors it, removing 1.2k LOC.

Scope

[x] This PR comprises a set of related changes with a common goal

How Has This Been Tested?

[x] Test Suite
[x] 3D QBMM

sbryngelson commented 1 month ago

When this works it will be my favorite PR to date, second to the Frontier merge and my LAPACK commit.

henryleberre commented 1 month ago

@sbryngelson I modified the 1D_qbmm example case to run on 8 A100s in 3D with different BCs. I compared the results against master using the ./mfc.sh packer and the results are EXACTLY the same:

 Comparing test/master.txt to test/master.txt:

   OK: The two packs are within tolerance (abs: 1.00E-12, rel: 1.00E-12).
   Average error: abs: 0.00E+00, rel: 0.00E+00.

This test was important because halo-exchange buffers are different when qbmm .and. .not. polytropic evaluates to true.

sbryngelson commented 1 month ago

wonderful. I think the Frontier case will run before maintenance and then I will merge. I won't merge anything else in the meantime anyway since all other PRs will also be waiting on Frontier CI.