search

MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
132 stars 56 forks source link

Silo doesn't build with gcc version >= 13 #428

Closed sbryngelson closed 1 month ago

sbryngelson commented 1 month ago

Silo doesn't build with gcc version >= 13. Particularly problematic for MacOS builds but will soon be important on other clusters as gcc versions creep forward (gcc14 is already available).

I've tested with openmpi and mpich.

Fails like this:

 $ cmake --build /Users/spencer/Downloads/mfc/build/staging/silo --target silo --parallel 8 --config Release

[ 12%] Creating directories for 'silo'
[ 25%] Performing download step (git clone) for 'silo'
Cloning into 'silo'...
remote: Enumerating objects: 14264, done.
remote: Counting objects: 100% (2900/2900), done.
remote: Compressing objects: 100% (915/915), done.
remote: Total 14264 (delta 2028), reused 2714 (delta 1951), pack-reused 11364
Receiving objects: 100% (14264/14264), 118.40 MiB | 2.25 MiB/s, done.
Resolving deltas: 100% (11313/11313), done.
HEAD is now at 438477c macOS: Handle deprecated stat64
[ 37%] Performing update step for 'silo'
[ 50%] Performing patch step for 'silo'
No local changes to save
[ 62%] Performing configure step for 'silo'
CMake Warning:
  Ignoring empty string ("") provided on the command line.

-- The CXX compiler identification is GNU 14.1.0
-- The C compiler identification is GNU 14.1.0
-- Checking whether CXX compiler has -isysroot
-- Checking whether CXX compiler has -isysroot - yes
-- Checking whether CXX compiler supports OSX deployment target flag
-- Checking whether CXX compiler supports OSX deployment target flag - yes
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/homebrew/bin/g++-14 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Checking whether C compiler has -isysroot
-- Checking whether C compiler has -isysroot - yes
-- Checking whether C compiler supports OSX deployment target flag
-- Checking whether C compiler supports OSX deployment target flag - yes
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/homebrew/bin/gcc-14 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Found HDF5: hdf5-static (found version "1.12.2")
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of off64_t
-- Check size of off64_t - failed
-- Looking for dlfcn.h
-- Looking for dlfcn.h - found
-- Looking for fcntl.h
-- Looking for fcntl.h - found
-- Looking for fnmatch.h
-- Looking for fnmatch.h - found
-- Looking for history.h
-- Looking for history.h - not found
-- Looking for ieeefp.h
-- Looking for ieeefp.h - not found
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Looking for memory.h
-- Looking for memory.h - found
-- Looking for readline.h
-- Looking for readline.h - not found
-- Looking for readline/history.h
-- Looking for readline/history.h - found
-- Looking for readline/readline.h
-- Looking for readline/readline.h - found
-- Looking for stdarg.h
-- Looking for stdarg.h - found
-- Looking for stdlib.h
-- Looking for stdlib.h - found
-- Looking for strings.h
-- Looking for strings.h - found
-- Looking for string.h
-- Looking for string.h - found
-- Looking for sys/fcntl.h
-- Looking for sys/fcntl.h - found
-- Looking for sys/stat.h
-- Looking for sys/stat.h - found
-- Looking for sys/time.h
-- Looking for sys/time.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Looking for fclose
-- Looking for fclose - found
-- Looking for fflush
-- Looking for fflush - found
-- Looking for fnmatch
-- Looking for fnmatch - found
-- Looking for fopen
-- Looking for fopen - found
-- Looking for fpclass
-- Looking for fpclass - not found
-- Looking for fprintf
-- Looking for fprintf - found
-- Looking for fread
-- Looking for fread - found
-- Looking for fseek
-- Looking for fseek - found
-- Looking for ftell
-- Looking for ftell - found
-- Looking for fwrite
-- Looking for fwrite - found
-- Looking for setvbuf
-- Looking for setvbuf - found
-- Looking for strerror
-- Looking for strerror - found
-- Looking for isnan
-- Looking for isnan - found
-- Looking for memmove
-- Looking for memmove - found
-- Looking for add_history
-- Looking for add_history - not found
-- Looking for stat64
-- Looking for stat64 - not found
-- Looking for stat
-- Looking for stat - found
-- The Fortran compiler identification is GNU 14.1.0
-- Checking whether Fortran compiler has -isysroot
-- Checking whether Fortran compiler has -isysroot - yes
-- Checking whether Fortran compiler supports OSX deployment target flag
-- Checking whether Fortran compiler supports OSX deployment target flag - yes
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Check for working Fortran compiler: /opt/homebrew/bin/gfortran-14 - skipped
-- Detecting Fortran/C Interface
-- Detecting Fortran/C Interface - Found GLOBAL and MODULE mangling
-- Configuring done (8.3s)
-- Generating done (0.0s)
-- Build files have been written to: /Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo-build
[ 75%] Performing build step for 'silo'
[  1%] Building C object CMakeFiles/pdb_detect.dir/src/pdb/detect.c.o
[  2%] Linking C executable bin/pdb_detect
Creating pdform.h using pdb_detect
Creating lite_pdb.h using mklite
Creating lite_score.h using mklite
[  2%] Built target pdb_detect
[  5%] Building C object CMakeFiles/silo.dir/src/netcdf/api.c.o
[  5%] Building C object CMakeFiles/silo.dir/src/debug/silo_debug.c.o
[  6%] Building C object CMakeFiles/silo.dir/src/netcdf/obj.c.o
[  8%] Building C object CMakeFiles/silo.dir/src/netcdf/silo_netcdf.c.o
[ 10%] Building C object CMakeFiles/silo.dir/src/filters/f_sample.c.o
[ 10%] Building C object CMakeFiles/silo.dir/src/netcdf/ent.c.o
[ 12%] Building C object CMakeFiles/silo.dir/src/netcdf/netcdf.c.o
[ 13%] Building C object CMakeFiles/silo.dir/src/filters/f_ale3d.c.o
[ 14%] Building C object CMakeFiles/silo.dir/src/netcdf/table.c.o
[ 16%] Building C object CMakeFiles/silo.dir/src/pdb/pdb.c.o
[ 17%] Building C object CMakeFiles/silo.dir/src/pdb/pdbdir.c.o
[ 18%] Building C object CMakeFiles/silo.dir/src/pdb/pdbio.c.o
[ 20%] Building C object CMakeFiles/silo.dir/src/pdb/pdbmm.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1810:2: warning: #warning MOVE TO PDLOW.C [-Wcpp]
 1810 | #warning MOVE TO PDLOW.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1818:2: warning: #warning MOVE TO PDMEMB.C [-Wcpp]
 1818 | #warning MOVE TO PDMEMB.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1826:2: warning: #warning MOVE TO PDLOW.C [-Wcpp]
 1826 | #warning MOVE TO PDLOW.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1877:2: warning: #warning MOVE TO PDLOW.C [-Wcpp]
 1877 | #warning MOVE TO PDLOW.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1886:2: warning: #warning MOVE TO PDLOW.C [-Wcpp]
 1886 | #warning MOVE TO PDLOW.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1896:2: warning: #warning MOVE TO PDBDIR.C [-Wcpp]
 1896 | #warning MOVE TO PDBDIR.C
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c: In function 'lite_PD_ln':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1903:2: warning: #warning MAYBE INCREASE MAXLINE FOR LEOSPACT [-Wcpp]
 1903 | #warning MAYBE INCREASE MAXLINE FOR LEOSPACT
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c: At top level:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/pdb/pdb.c:1980:2: warning: #warning SHOULD GO IN PDBMM.c [-Wcpp]
 1980 | #warning SHOULD GO IN PDBMM.c
      |  ^~~~~~~
[ 21%] Building C object CMakeFiles/silo.dir/src/pdb/pdbx.c.o
[ 22%] Building C object CMakeFiles/silo.dir/src/pdb/pdconv.c.o
[ 24%] Building C object CMakeFiles/silo.dir/src/pdb/pdlow.c.o
[ 25%] Building C object CMakeFiles/silo.dir/src/pdb/pdmemb.c.o
[ 27%] Building C object CMakeFiles/silo.dir/src/pdb/pdpath.c.o
[ 28%] Building C object CMakeFiles/silo.dir/src/pdb/pdrdwr.c.o
[ 29%] Building C object CMakeFiles/silo.dir/src/pdb_drv/silo_pdb.c.o
[ 31%] Building C object CMakeFiles/silo.dir/src/score/memmove.c.o
[ 32%] Building C object CMakeFiles/silo.dir/src/score/scctl.c.o
[ 33%] Building C object CMakeFiles/silo.dir/src/score/scctla.c.o
[ 35%] Building C object CMakeFiles/silo.dir/src/score/schash.c.o
[ 36%] Building C object CMakeFiles/silo.dir/src/score/scstr.c.o
[ 37%] Building C object CMakeFiles/silo.dir/src/silo/alloc.c.o
[ 39%] Building C object CMakeFiles/silo.dir/src/silo/extface.c.o
[ 40%] Building C object CMakeFiles/silo.dir/src/silo/silo.c.o
[ 41%] Building C object CMakeFiles/silo.dir/src/silo/silo_ns.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/alloc.c: In function 'DBIsEmptyQuadmesh':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/alloc.c:910:2: warning: #warning CHECK THIS LOGIC. IF ANY DIM>0, IT IS NOT EMPTY [-Wcpp]
  910 | #warning CHECK THIS LOGIC. IF ANY DIM>0, IT IS NOT EMPTY
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/alloc.c: In function 'DBIsEmptyQuadvar':
[ 43%] Building C object CMakeFiles/silo.dir/src/silo/utils.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/alloc.c:1357:2: warning: #warning CHECK THIS LOGIC [-Wcpp]
 1357 | #warning CHECK THIS LOGIC
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:75:2: warning: #warning SIMPLIFY HEADER INCLUSION LOGIC [-Wcpp]
   75 | #warning SIMPLIFY HEADER INCLUSION LOGIC
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:235:2: warning: #warning REDUCE USE OF THIS CONSTRUCT [-Wcpp]
  235 | #warning REDUCE USE OF THIS CONSTRUCT
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:295:2: warning: #warning FIX THIS [-Wcpp]
  295 | #warning FIX THIS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'db_FreeToc':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:1139:2: warning: #warning WE SHOULD PROBABLY JUST EITHER MAKE THIS CONSISTENT OR PERHAPS COPY ALL CHARS INTO LINK@TARGET format [-Wcpp]
 1139 | #warning WE SHOULD PROBABLY JUST EITHER MAKE THIS CONSISTENT OR PERHAPS COPY ALL CHARS INTO LINK@TARGET format
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBLs':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:1746:2: warning: #warning CLEAN UP IS LOST IN ABOVE EARLY RETURNS [-Wcpp]
 1746 | #warning CLEAN UP IS LOST IN ABOVE EARLY RETURNS
      |  ^~~~~~~
[ 44%] Building C object CMakeFiles/silo.dir/src/taurus/silo_taurus.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: At top level:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:2549:2: warning: #warning WHAT ABOUT FORCESINGLE SHOWERRORS [-Wcpp]
 2549 | #warning WHAT ABOUT FORCESINGLE SHOWERRORS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBGrabDriver':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:2860:2: warning: #warning FIX GLOBAL LOCK [-Wcpp]
 2860 | #warning FIX GLOBAL LOCK
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: At top level:
[ 45%] Building C object CMakeFiles/silo.dir/src/taurus/taurus.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:3603:2: warning: #warning ADD DBSHOWERRORSFILE [-Wcpp]
 3603 | #warning ADD DBSHOWERRORSFILE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBShowErrors':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:3620:2: warning: #warning GET RID OF SUSPEND/RESUME STUFF [-Wcpp]
 3620 | #warning GET RID OF SUSPEND/RESUME STUFF
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'db_InitFileGlobals':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:3996:2: warning: #warning ADD compressionMinSize [-Wcpp]
 3996 | #warning ADD compressionMinSize
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:4000:2: warning: #warning CORRECT INITIALIZATION OF compressionErrmode [-Wcpp]
 4000 | #warning CORRECT INITIALIZATION OF compressionErrmode
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:4004:61: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
 4004 |     dbfile->pub.file_scope_globals->compressionParams       = DB_CHAR_PTR_NOT_SET;
      |                                                             ^
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBClose':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:4442:2: warning: #warning IS ORDER OF OPS CORRECT HERE [-Wcpp]
 4442 | #warning IS ORDER OF OPS CORRECT HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'db_validate_copy_step':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:5867:2: warning: #warning ONLY IF SRC SIZE SMALLER THAN DST SIZE [-Wcpp]
 5867 | #warning ONLY IF SRC SIZE SMALLER THAN DST SIZE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'db_can_overwrite_dstobj_with_srcobj':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:5964:2: warning: #warning SHOULDNT WE USE FILE LENGTH FUNCTIONS HERE [-Wcpp]
 5964 | #warning SHOULDNT WE USE FILE LENGTH FUNCTIONS HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:5976:2: warning: #warning DISALLOW SIMLINKS FOR NOW [-Wcpp]
 5976 | #warning DISALLOW SIMLINKS FOR NOW
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'db_copy_single_object_abspath':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6044:2: warning: #warning CHECK ARGS HERE. ALLOW FOR NULL dstFile AND dstObjAbsName [-Wcpp]
 6044 | #warning CHECK ARGS HERE. ALLOW FOR NULL dstFile AND dstObjAbsName
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6045:2: warning: #warning WHY CHECK dstType HERE [-Wcpp]
 6045 | #warning WHY CHECK dstType HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6074:2: warning: #warning USE FILE-BASED FUNCTION WHEN AVAILABLE [-Wcpp]
 6074 | #warning USE FILE-BASED FUNCTION WHEN AVAILABLE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBCp':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6291:2: warning: #warning WHAT ABOUT API MACROS. MAYBE NOT NEEDED SINCE NOT CALLING DOWN INTO DRIVERS [-Wcpp]
 6291 | #warning WHAT ABOUT API MACROS. MAYBE NOT NEEDED SINCE NOT CALLING DOWN INTO DRIVERS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6292:2: warning: #warning WHAT ABOUT -f (force) OPTION [-Wcpp]
 6292 | #warning WHAT ABOUT -f (force) OPTION
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6313:2: warning: #warning WARN ABOUT CERTAIN OPTIONS NOT YET SUPPORTED [-Wcpp]
 6313 | #warning WARN ABOUT CERTAIN OPTIONS NOT YET SUPPORTED
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6401:2: warning: #warning FIX LEAKS WITH EARLY RETURN HERE [-Wcpp]
 6401 | #warning FIX LEAKS WITH EARLY RETURN HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6509:18: warning: passing argument 1 of 'free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
 6509 |             free(srcDirBaseName);
      |                  ^~~~~~~~~~~~~~
In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/stdlib.h:128,
                 from /Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:85:
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/malloc/_malloc.h:56:12: note: expected 'void *' but argument is of type 'const char *'
   56 | void  free(void * __unsafe_indexable);
      |            ^~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBGetPartialObject':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:6688:2: warning: #warning FIX THIS METHOD [-Wcpp]
 6688 | #warning FIX THIS METHOD
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: At top level:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:8210:2: warning: #warning DO WE NEED THIS METHOD [-Wcpp]
 8210 | #warning DO WE NEED THIS METHOD
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBPutMaterial':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:8987:2: warning: #warning BETTER PLACE TO NULL THESE [-Wcpp]
 8987 | #warning BETTER PLACE TO NULL THESE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBPutMultimat':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:9388:2: warning: #warning BETTER PLACE TO NULL THESE [-Wcpp]
 9388 | #warning BETTER PLACE TO NULL THESE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBPutZonelist2':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:10381:2: warning: #warning HI AND LO OFFSET NOT VALID IN PRESENCE OF EXPLICIT GHOST LABELS [-Wcpp]
10381 | #warning HI AND LO OFFSET NOT VALID IN PRESENCE OF EXPLICIT GHOST LABELS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c: In function 'DBStringArrayToStringList':
[ 47%] Building C object CMakeFiles/silo.dir/src/unknown/silo_unknown.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo.c:13364:2: warning: #warning TEST THIS LOGIC [-Wcpp]
13364 | #warning TEST THIS LOGIC
      |  ^~~~~~~
[ 48%] Building C object CMakeFiles/silo.dir/src/silo/silo_f.c.o
[ 50%] Building C object CMakeFiles/silo.dir/src/hdf5_drv/H5FDsilo.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/H5FDsilo.c:508:2: warning: #warning REMOVE ME [-Wcpp]
  508 | #warning REMOVE ME
      |  ^~~~~~~
[ 51%] Building C object CMakeFiles/silo.dir/src/hdf5_drv/silo_hdf5.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/H5FDsilo.c: In function 'H5FD_silo_get_eof':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/H5FDsilo.c:2001:2: warning: #warning TAKE ADVANTAGE OF TYPE INFO HERE [-Wcpp]
 2001 | #warning TAKE ADVANTAGE OF TYPE INFO HERE
      |  ^~~~~~~
In file included from /Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:73:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5_private.h:111:2: warning: #warning REMOVE db_hdf5_CpListedObjects [-Wcpp]
  111 | #warning REMOVE db_hdf5_CpListedObjects
      |  ^~~~~~~
In file included from /Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5_private.h:67:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_get_obj_dsnames':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:1812:45: error: passing argument 1 of '_db_safe_strdup' makes pointer from integer without a cast [-Wint-conversion]
 1812 |             (*dsnames)[i] = strdup(m.MEMNAME[i]);                \
      |                                    ~~~~~~~~~^~~
      |                                             |
      |                                             char
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo_private.h:939:35: note: in definition of macro 'strdup'
  939 | #define strdup(s) _db_safe_strdup(s)
      |                                   ^
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:1869:13: note: in expansion of macro 'DB_OBJ_CASE'
 1869 |             DB_OBJ_CASE(DB_CURVE, DBcurve_mt, npts?1:1, yvarname)
      |             ^~~~~~~~~~~
In file included from /Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/silo/silo_private.h:79:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo-build/include/silo.h:2214:56: note: expected 'const char *' but argument is of type 'char'
 2214 | SILO_API extern char *                 _db_safe_strdup(const char *);
      |                                                        ^~~~~~~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_InitCallbacks':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:2802:2: warning: #warning GET RID OF CPLISTEDOBJECTS [-Wcpp]
 2802 | #warning GET RID OF CPLISTEDOBJECTS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_set_compression':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:3354:2: warning: #warning WHAT ABOUT NULL RETURN FROM DBGETCOMPRESSION [-Wcpp]
 3354 | #warning WHAT ABOUT NULL RETURN FROM DBGETCOMPRESSION
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:3387:2: warning: #warning FIX MISSING .compressionMinsize member [-Wcpp]
 3387 | #warning FIX MISSING .compressionMinsize member
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:3407:2: warning: #warning QUERY FILE LEVEL COMPRESSION PARAMS HERE [-Wcpp]
 3407 | #warning QUERY FILE LEVEL COMPRESSION PARAMS HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'load_toc':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:4134:2: warning: #warning REVISIT THIS CODE BLOCK [-Wcpp]
 4134 | #warning REVISIT THIS CODE BLOCK
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_resolvename':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:4751:2: warning: #warning HARD CODED SIZE HERE [-Wcpp]
 4751 | #warning HARD CODED SIZE HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_process_file_options':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:4977:2: warning: #warning FIX ME...THIS NEEDS TO BE CONDITION ON COMPAT MODE WORKS FOR 1.8.0 [-Wcpp]
 4977 | #warning FIX ME...THIS NEEDS TO BE CONDITION ON COMPAT MODE WORKS FOR 1.8.0
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:4986:2: warning: #warning SET FRIENDLY NAMES TO 2 but only at file level [-Wcpp]
 4986 | #warning SET FRIENDLY NAMES TO 2 but only at file level
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5024:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]
 5024 | #warning REMOVED WINDOWS SPECIFIC CHECK
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5115:2: warning: #warning DO WE STILL NEED THIS [-Wcpp]
 5115 | #warning DO WE STILL NEED THIS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5175:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]
 5175 | #warning REMOVED WINDOWS SPECIFIC CHECK
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5295:2: warning: #warning PUT UDATA POINTER IN DBFILE pointer so it can be freed with file is closed. [-Wcpp]
 5295 | #warning PUT UDATA POINTER IN DBFILE pointer so it can be freed with file is closed.
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5530:2: warning: #warning FIX THIS [-Wcpp]
 5530 | #warning FIX THIS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_Open':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5909:2: warning: #warning QUERY FILE IMAGE STUFF HERE TO GET UDATA PTR [-Wcpp]
 5909 | #warning QUERY FILE IMAGE STUFF HERE TO GET UDATA PTR
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_Create':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:5993:2: warning: #warning BACKWARD COMPAT ISSUE FOR HDF5 [-Wcpp]
 5993 | #warning BACKWARD COMPAT ISSUE FOR HDF5
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:6030:2: warning: #warning FIX FILE SCOPE GLOBAL INITIALIZATION [-Wcpp]
 6030 | #warning FIX FILE SCOPE GLOBAL INITIALIZATION
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'copy_obj':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:6496:2: warning: #warning WHY THIS SIZE [-Wcpp]
 6496 | #warning WHY THIS SIZE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: At top level:
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:6667:2: warning: #warning REMOVE THIS MAYBE [-Wcpp]
 6667 | #warning REMOVE THIS MAYBE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_WriteObject':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:7406:2: warning: #warning COMPATABILITY ISSUE [-Wcpp]
 7406 | #warning COMPATABILITY ISSUE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_get_var_byte_length':
[ 52%] Building C object CMakeFiles/silo.dir/src/hdf5_drv/H5Zzfp.c.o
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:7781:2: warning: #warning REMOVED db_perror CALLS [-Wcpp]
 7781 | #warning REMOVED db_perror CALLS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_WriteCKZ':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8429:2: warning: #warning WHAT IF EXISTING DATASET WAS COMPRESSED [-Wcpp]
 8429 | #warning WHAT IF EXISTING DATASET WAS COMPRESSED
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8473:2: warning: #warning COMPARE TO -1 OR TO NEGATIVE [-Wcpp]
 8473 | #warning COMPARE TO -1 OR TO NEGATIVE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8497:2: warning: #warning COMPARE TO -1 OR NEGATIVE [-Wcpp]
 8497 | #warning COMPARE TO -1 OR NEGATIVE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_GetObject':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8724:2: warning: #warning THIS IFDEFD CODE IS IN TRANSITION TO BETTER GENERIC OBJECTS [-Wcpp]
 8724 | #warning THIS IFDEFD CODE IS IN TRANSITION TO BETTER GENERIC OBJECTS
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8823:2: warning: #warning REVISIT THIS CLEANUP CODE. IS THERE A BETTER SYMBOLIC VALUE THAN -1 [-Wcpp]
 8823 | #warning REVISIT THIS CLEANUP CODE. IS THERE A BETTER SYMBOLIC VALUE THAN -1
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8830:2: warning: #warning USE FREE() MACRO HERE [-Wcpp]
 8830 | #warning USE FREE() MACRO HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:8844:2: warning: #warning USE FREE() MACRO HERE [-Wcpp]
 8844 | #warning USE FREE() MACRO HERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c: In function 'db_hdf5_PutMultimat':
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:14354:2: warning: #warning REPLACE WITH STRING UTILITIES [-Wcpp]
14354 | #warning REPLACE WITH STRING UTILITIES
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:14394:2: warning: #warning IS THIS TAKEN CARE OF ELSEWHERE [-Wcpp]
14394 | #warning IS THIS TAKEN CARE OF ELSEWHERE
      |  ^~~~~~~
/Users/spencer/Downloads/mfc/build/staging/silo/silo-prefix/src/silo/src/hdf5_drv/silo_hdf5.c:14406:2: warning: #warning IS THIS TAKEN CARE OF ELSEWHERE [-Wcpp]
14406 | #warning IS THIS TAKEN CARE OF ELSEWHERE
      |  ^~~~~~~
make[6]: *** [CMakeFiles/silo.dir/src/hdf5_drv/silo_hdf5.c.o] Error 1
make[6]: *** Waiting for unfinished jobs....
[ 54%] Building C object CMakeFiles/silo.dir/src/zfp-0.5.5/src/bitstream.c.o
make[5]: *** [CMakeFiles/silo.dir/all] Error 2
make[4]: *** [all] Error 2
make[3]: *** [silo-prefix/src/silo-stamp/silo-build] Error 2
make[2]: *** [CMakeFiles/silo.dir/all] Error 2
make[1]: *** [CMakeFiles/silo.dir/rule] Error 2
make: *** [silo] Error 2

Error: Failed to build the silo target.

./mfc.sh: line 49: 36670 Terminated: 15          python3 "$(pwd)/toolchain/main.py" "$@"
wilfonba commented 1 month ago

Relevant issue on the silo repository: https://github.com/LLNL/Silo/issues/375

sbryngelson commented 1 month ago

Does it work w/ v13 or no? I thought it did but haven't double checked.