This PR enables STL patches in IBM. Adding 3D, MPI communication, and GPU part of the code now. If you have any case in mind that I can run for validating the approach, please let me know and I can test it for you. Any idea is appreciated.
Type of change
Please delete options that are not relevant.
[x] New feature (non-breaking change which adds functionality)
Scope
[x] This PR comprises a set of related changes with a common goal
How Has This Been Tested?
[x] 2D Test using simple geometry such as rectangles and compare results between levelset function for STL and the levelset function for rectangle.
What computers and compilers did you use to test this: MacOS 12.2.1
Checklist
[ ] I have added comments for the new code
[ ] I added Doxygen docstrings to the new code
[ ] I have made corresponding changes to the documentation (docs/)
[ ] I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
[ ] I have added example cases in examples/ that demonstrate my new feature performing as expected.
They run to completion and demonstrate "interesting physics"
[ ] I ran ./mfc.sh format before committing my code
[ ] New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
[ ] This PR does not introduce any repeated code (it follows the DRY principle)
[ ] I cannot think of a way to condense this code and reduce any introduced additional line count
If your code changes any code source files (anything in src/simulation)
To make sure the code is performing as expected on GPU devices, I have:
[ ] Checked that the code compiles using NVHPC compilers
[ ] Checked that the code compiles using CRAY compilers
[ ] Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
[ ] Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
[ ] Enclosed the new feature via nvtx ranges so that they can be identified in profiles
[ ] Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
[ ] Ran an Omniperf profile using ./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.
[ ] Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature
Description
This PR enables STL patches in IBM. Adding 3D, MPI communication, and GPU part of the code now. If you have any case in mind that I can run for validating the approach, please let me know and I can test it for you. Any idea is appreciated.
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
https://github.com/MFlowCode/MFC/assets/98496194/64a0b066-8252-4e3e-a87d-1957fd9167e0
https://github.com/MFlowCode/MFC/assets/98496194/6265e0d4-4744-46a2-a786-30c72dd18f51
https://github.com/MFlowCode/MFC/assets/98496194/9972202b-86fb-4b25-97f2-eddeae9e57f2
Test Configuration:
Checklist
docs/)examples/that demonstrate my new feature performing as expected. They run to completion and demonstrate "interesting physics"./mfc.sh formatbefore committing my codeIf your code changes any code source files (anything in
src/simulation)To make sure the code is performing as expected on GPU devices, I have:
nvtxranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.