Fixed MacOS CI with no-debug flag only

okBrian commented 3 weeks ago

Description

Fixed the MacOS CI specifically with the no-debug flag Unsure whats wrong with the debug one

Fixes #444

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Scope

[x] This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

[x] check if MacOS --no-debug would build w/o my lines
[x] check if MacOS --no-debug would build with my lines

Test Configuration:

GitHub Runners

Checklist

[x] I ran ./mfc.sh format before committing my code
[x] This PR does not introduce any repeated code (it follows the DRY principle)
[x] I cannot think of a way to condense this code and reduce any introduced additional line count

sbryngelson commented 3 weeks ago

hmm. do you want to prepend the existing paths instead of replacing them?

    export CPATH=/opt/homebrew/include
    export LIBRARY_PATH=/opt/homebrew/lib

to export CPATH="/opt/homebrew/include":$CPATH

This might fix the debug issue.

(I may be messing up the exact syntax).

sbryngelson commented 3 weeks ago

There's also the "recommendations" here:

https://apple.stackexchange.com/questions/40704/homebrew-installed-libraries-how-do-i-use-them

okBrian commented 3 weeks ago

I did some more experimentation here's what I figured out.

mpich is not the issue
gcc 13.3 doesn't build with my changes at all
gcc 14 builds correctly with my changes but requires the pre-release: 20240611.1 MacOS image
- There is no current support in changing or choosing a pre-release image
gcc 14 doesn't build w/o my changes
brew auto links libraries with brew link and unlink so its unlikely that's the cause

Heres the branch I tested everything on https://github.com/okBrian/MFC/tree/mac

So I think the best course of action here is to merge these changes and wait for the next release of MacOS images (20240611.1) to release and the MacOS CI should be fixed.

sbryngelson commented 3 weeks ago

I did some more experimentation here's what I figured out.

mpich is not the issue

gcc 13.3 doesn't build with my changes at all

gcc 14 builds correctly with my changes but requires the pre-release: 20240611.1 MacOS image

There is no current support in changing or choosing a pre-release image

gcc 14 doesn't build w/o my changes

brew auto links libraries with brew link and unlink so its unlikely that's the cause Heres the branch I tested everything on okBrian/MFC@mac

This is all very believable to me. I guess this is a draft PR to be merged when the MacOS runner is updated? Do we have an approximate known date for that? What about --debug? Are we able to manually specify a pre-release MacOS image?

okBrian commented 3 weeks ago

--debug and no-debug have no affect on the results since --no-debug worked on my actions and debug worked on this repo. I also tested this in my mac branch. The only difference between the test that failed and passed I could find was the MacOS Image.

sbryngelson commented 3 weeks ago

Understood. Do we have timeline for new MacOS image or how to specify it?

okBrian commented 3 weeks ago

From what I searched you can't switch to a pre-release image specifically. For the release data/timeline I'll make a post here https://github.com/actions/runner-images/discussions since I can't find it anywhere.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.91%. Comparing base (596ef8b) to head (7916e18).

:exclamation: Current head 7916e18 differs from pull request most recent head da313e0

Please upload reports for the commit da313e0 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #469 +/- ## ======================================= Coverage 57.91% 57.91% ======================================= Files 55 55 Lines 14230 14230 Branches 1854 1854 ======================================= Hits 8242 8242 Misses 5452 5452 Partials 536 536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

okBrian commented 3 weeks ago

Before I asked in discussion I just read a bit more in their README. "Usually, image deployment takes 2-3 days, and documentation in the main branch is only updated when deployment is finished." The 20240611.1 has the tag "Deploying" in their README so I think in 2-3 days it should be up and running over the previous image.

okBrian commented 2 weeks ago

Hey, the MacOS Image is fully deployed so assuming the test pass this should be it. Seen here - https://github.com/actions/runner-images/blob/main/README.md

MFlowCode / MFC