MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
132 stars 56 forks source link

Hotfix: Allow certain case parameters to be analytic expressions again #473

Closed AiredaleDev closed 2 weeks ago

AiredaleDev commented 2 weeks ago

Description

After addressing GH-424, I broke parameters like those found in 1D_shuosher and 1D_titarevtorro which have analytic values -- they were falsely rejected as "strings" when they should have been accepted.

Type of change

Please delete options that are not relevant.

Scope

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

 Pre-processing a 999x0x0 case on 1 rank(s)
 Processing patch           1
 Processing patch           2
 Invalid hcid specified for patch 2
STOP 1

This is behavior also appears on v4.8.2, before the new case validation was implemented. This may be specific to my machine.

Test Configuration:

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.91%. Comparing base (ae76acf) to head (5c075a0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #473 +/- ## ======================================= Coverage 57.91% 57.91% ======================================= Files 55 55 Lines 14230 14230 Branches 1854 1854 ======================================= Hits 8242 8242 Misses 5452 5452 Partials 536 536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.