Closed AiredaleDev closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 57.91%. Comparing base (
ae76acf
) to head (5c075a0
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
After addressing GH-424, I broke parameters like those found in
1D_shuosher
and1D_titarevtorro
which have analytic values -- they were falsely rejected as "strings" when they should have been accepted.Type of change
Please delete options that are not relevant.
Scope
If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
./mfc.sh test
passes1D_shuosher
-- Simulation ran to completion1D_titarevtorro
-- Case file passed validation but preprocessing failed:This is behavior also appears on v4.8.2, before the new case validation was implemented. This may be specific to my machine.
Test Configuration:
Checklist
./mfc.sh format
before committing my code