Added Intent to parameters that needed it
Formatting to be more uniform with pre_proc and common
Fixes #479
Type of change
[x] Something else
Scope
[x] This PR comprises a set of related changes with a common goal
How Has This Been Tested?
[x] Github Actions
[x] Locally
Test Configuration:
Ubuntu 22.04.4 LTS, gcc14
Github Actions
Checklist
[x] I ran ./mfc.sh format before committing my code
[x] New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
[x] This PR does not introduce any repeated code (it follows the DRY principle)
[x] I cannot think of a way to condense this code and reduce any introduced additional line count
If your code changes any code source files (anything in src/simulation)
To make sure the code is performing as expected on GPU devices, I have:
[x] Checked that the code compiles using NVHPC compilers
[ ] Checked that the code compiles using CRAY compilers
[ ] Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
[ ] Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
[ ] Enclosed the new feature via nvtx ranges so that they can be identified in profiles
[ ] Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
[ ] Ran an Omniperf profile using ./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.
[ ] Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature
Description
Added Intent to parameters that needed it Formatting to be more uniform with pre_proc and common
Fixes #479
Type of change
[x] Something else
Scope
[x] This PR comprises a set of related changes with a common goal
How Has This Been Tested?
[x] Github Actions
[x] Locally
Test Configuration:
Ubuntu 22.04.4 LTS, gcc14 Github Actions
Checklist
./mfc.sh formatbefore committing my codeIf your code changes any code source files (anything in
src/simulation)To make sure the code is performing as expected on GPU devices, I have:
nvtxranges so that they can be identified in profiles./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.