MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics
https://mflowcode.github.io
MIT License
142 stars 65 forks source link

Nsight Systems profiling NVTX blocks are broken #501

Closed sbryngelson closed 2 months ago

sbryngelson commented 3 months ago

For NVIDIA GPU Nsight Systems profiling, the NVTX blocks were, at some point, broken. It is unclear why, though it seems like it should be easy to track down. An example is in the image below for a 3D case.

Broken (current): Screenshot 2024-07-03 at 14 27 18

Working (old):

Screenshot 2023-05-05 at 09 57 57
AiredaleDev commented 2 months ago

Out of curiosity, do you know when you most recently creating a working profile? I figured the fastest way I could address this is to determine which commit broke profiling.

sbryngelson commented 2 months ago

I am not sure. I suspect it was either the PR that introduced AMD GPU support (I think @anandrdbz as primary author but it has like 20 contributors), or @wilfonba's PR that abstracted out all RHS functionality to different subroutines. I'm not sure which (or it could be something else).