Fix 1D_impact, 1D_qbmm, and 2D_5wave_quasi1D

MFlowCode / MFC

Exascale simulation of multiphase/physics fluid dynamics

https://mflowcode.github.io

MIT License

132 stars 58 forks source link

Fix 1D_impact, 1D_qbmm, and 2D_5wave_quasi1D #502

Closed okBrian closed 1 week ago

okBrian commented 1 week ago

Description

Fixed examples 1D_impact, 1D_qbmm, and 2D_5wave_quasi1D

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Scope

[x] This PR comprises a set of related changes with a common goal

How Has This Been Tested?

[x] Tested on my Local Machine on 1 Node

Test Configuration:

Ubuntu 22.04.4 LTS, gcc14

Checklist

[x] I ran ./mfc.sh format before committing my code
[x] This PR does not introduce any repeated code (it follows the DRY principle)
[x] I cannot think of a way to condense this code and reduce any introduced additional line count

okBrian commented 1 week ago

I am not entirely sure these have affected what the examples are actually trying to show. These are just the changes the examples needed for it to work on my local machine.

sbryngelson commented 1 week ago

This looks right to me. I think case_dir or whatever is a deprecated input variable. You could check to see if it gets used anywhere in the actual code. Can you remove it from the toolchain (and any remaining input files) if it doesn't? @okBrian

sbryngelson commented 1 week ago

Also delete, not comment, the case_dir lines

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.37%. Comparing base (37b8838) to head (6a37694).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #502 +/- ## ======================================= Coverage 58.37% 58.37% ======================================= Files 57 57 Lines 14440 14440 Branches 1892 1892 ======================================= Hits 8429 8429 Misses 5449 5449 Partials 562 562 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sbryngelson commented 1 week ago

@henryleberre how does the code know what the case_dir is? it looks like it needs to be specified in the case.py file and passed into a .inp file for NAMELIST in the source, but I don't see anywhere in the toolchain where it's auto-generating the case_dir parameter/value or even setting a default? I must be missing something because everything is working as intended, but still curious.

Also, if case_dir is not to be specified in case.py, then it should be removed from CASE_DICTS in toolchain, right?