MGK82 / PackTracker

Plugin for HearthstoneDeckTracker
MIT License
38 stars 10 forks source link

Epic and Legendary cards are being spoiled (despite setting off) #14

Open robertsynoradzki opened 6 years ago

robertsynoradzki commented 6 years ago

I am one of those people who really don't want to know what's in their pack until they find themselves. I have my setting "Spoil" set to "off", but when I open packs, having found an Epic or Legendary quality is still super obvious because the chart column(s) zero out immediately after opening the pack (instead of after having uncovered all 5 cards).

Consider detecting that all 5 cards have been uncovered before updating the chart. Alternatively consider adding option "Only update columns on NEXT pack opened" vel "Show statistics for up to previous pack opened ONLY" vel "Lag statistics by one pack".

MGK82 commented 6 years ago

Afaik there is no way to tell, when cards are flipped. I'll do some research or concider a delayed update.

For now, I suggest you to turn the pity timer overlay off in Pack Tracker's settings. The spoiled pop up is a little box popping up displaying all contained cards and has nothing to do with the pity timer overlay.

You can still find not only your current pity timer, but also your pity timer history across all recorded sets manually in the pity timer window by clicking on PLUGINS > Pack Tracker > PityTimers. This window, like any other, also updates (in the background) when you open a pack.

robertsynoradzki commented 6 years ago

Thanks for your response! I wish you good luck in your research. Perhaps listening for 5 mouse left button up events is way better than a timer. If you like that idea, then getting the (x,y) location of the click (and adjusting it to Hearthstone resolution and possible windowed mode) could be a perfect solution.

2 kwi 2018 11:15 "MGK82" notifications@github.com napisał(a):

Afaik there is no way to tell, when cards are flipped. I'll do some research or concider a delayed update.

For now, I suggest you to turn the pity timer overlay off in Pack Tracker's settings. You can still find not only your current pity timer, but also your pity timer history across all recorded sets manually in the pity timer window by clicking on PLUGINS > Pack Tracker > PityTimers. This window, like any other, also updates when you open a pack.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MGK82/PackTracker/issues/14#issuecomment-377891684, or mute the thread https://github.com/notifications/unsubscribe-auth/ATEnc5WbUa6bNxsTLL4P9CU_Ik6SONquks5tkexEgaJpZM4S_5Vp .