search

MGK82 / PackTracker

Plugin for HearthstoneDeckTracker
MIT License
38 stars 10 forks source link

Will this automatically work with new expansions or does it need to be updated #20

Open elmstreetvictim opened 5 years ago

elmstreetvictim commented 5 years ago

I see the the localization document that was last updated 4 months ago for Rastakhan. Is it possible to update this file now, since we know the name of the expansion? Or is the dictionary and the integer key an item that is not known at this time? IE the Witchwood is like 31, Boomsday is 38 and Rastakhan is 40.

I want to open a lot of packs on launch day and want to make sure I can keep track of the pity timers.

Thank you all.

MGK82 commented 5 years ago

Hello. Even if the expansion's id is not provided for localization, it will still be recorded. The only downside is, that the expansion will be represented by its id, instaed of a propper name, until the updated localization comes into play.

I always have to wait for the HDT guys to update there code, which will expose the id to me. So far, the added id is 49 with the title "DALARAN", which confuses me. I hope it is the right id.

If not, we will see on release and I can update it again. I just wouldn't like to have two updates.

Anyway, again: No data will be lost and everything will be recorded as usual, if there is no localization for a new expansion in time. It will only look ugly on the surface, because there is nothing else to show than the blank id.

elmstreetvictim commented 5 years ago

Thank you. I will have the plugin active tomorrow in the client when I open my packs. Then after it’s updated I should be able to keep all my old data.

Thank you for the work on this

Get Outlook for iOShttps://aka.ms/o0ukef

From: MGK82 notifications@github.com Sent: Monday, April 8, 2019 1:45 PM To: MGK82/PackTracker Cc: elmstreetvictim; Author Subject: Re: [MGK82/PackTracker] Will this automatically work with new expansions or does it need to be updated (#20)

Hello. Even if the expansion's id is not provided for localization, it will still be recorded. The only downside is, that the expansion will be represented by its id, instaed of a propper name, until the updated localization comes into play.

I always have to wait for the HDT guys to update there code, which will expose the id to me. So far, the added id is 49 with the title "DALARAN", which confuses me. I hope it is the right id.

If not, we will see on release and I can update it again. I just wouldn't like to have two updates.

Anyway, again: No data will be lost and everything will be recorded as usual, if there is no localization for a new expansion in time. It will only look ugly on the surface, because there is nothing else to show than the blank id.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MGK82/PackTracker/issues/20#issuecomment-480956500, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjX_wBGmnffA4NKYr9LUZOIIiA8zyFzJks5ve45dgaJpZM4cE_KB.

MGK82 commented 5 years ago

Sorry, I guess I havn't made it clear. I just released an update. You can get it already through the autoupdate or manually.

Just in case the id isn't correct, there will be another update tomorrow.

elmstreetvictim commented 5 years ago

Awesome, thanks!!!

Get Outlook for iOShttps://aka.ms/o0ukef

From: MGK82 notifications@github.com Sent: Monday, April 8, 2019 1:48 PM To: MGK82/PackTracker Cc: elmstreetvictim; Author Subject: Re: [MGK82/PackTracker] Will this automatically work with new expansions or does it need to be updated (#20)

Sorry, I guess I havn't made it clear. I just released an update. You can get it through the autoupdate or manually already.

Just in case the id isn't correct, there will be another update tomorrow.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MGK82/PackTracker/issues/20#issuecomment-480957859, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AjX_wLX5s1D4rSVP0qmH34fYq0X8T9ZBks5ve48WgaJpZM4cE_KB.