search

MGK82 / PackTracker

Plugin for HearthstoneDeckTracker
MIT License
38 stars 10 forks source link

Classic Duplicated Pack #3

Closed gony06 closed 6 years ago

gony06 commented 6 years ago

Good morning, first of all, apologize for my English. I contact you to inform that after updating to the latest version, when opening a classic pack, the plug-in pack tracker has counted it 2 times, and I would like to know how to solve it. Thank you very much.

sdbds commented 6 years ago

me too. i think that turn on spoil and Pity Timer Overlay at the same time. when i close Pity Timer Overlay,it worked.

gony06 commented 6 years ago

Ok, I "fixed" it. I edited the file History.xml located in AppData\Roaming\HearthstoneDeckTracker\PackTracker

MGK82 commented 6 years ago

Hmm... that should not be possible to happen. I opened my classic pack from tavern brawl last night and had no issues. The overlays are pure UI and don't have anything to do with the store mechanism, nor with the history stored to your ram. Actually, the history object in memory tells the overlays to appear/update, not the other way around.

I gonna have a look into it. I have an idea how that could happen.

For now, @gony06 is right. The history is stored on your hdd. Click on plugin folder in HDT, go one folder up, then \PackTracker. There is the history.xml and the settings.xml. It's plain simple xml, you can remove packs with a simple text editor. Just make sure to not produce syntax errors in the xml. The plugin will load an empty history to memory in that case. If you open a pack then, it will override your existing history.xml. with the empty history. Make a backup before you edit it.

gony06 commented 6 years ago

Thank you very much :)

MGK82 commented 6 years ago

Ok, I had it tested and it was actually possible to have packs stored multiple times. To reproduce it, you need to turn the pack tracker off and on again. For every time it was turned on, it would store a pack one more time. But this did not come through the last patch. It was there since the very first prototype because I wasn't fully away of the behave of HDT's Plugin-Interface at that time. I hope that covers your cases. A fix is already live and should come to you through the auto update or can be download, just as usual.

Hf and please report more, share your ideas or tell me that I make a great job. ;)

PS. I keep this open for another day in case there is more to discuss.