Grand Update PackNameConverter.cs

TheMrKochan commented 3 years ago

Updated the names of the packs and added new translations. @sgkoishi I hope you won't be too offended if I use your translations and the work in General as a basis. Please don't swear, this is my first time trying to make edits :)

TheMrKochan commented 3 years ago

@MGK82 I think it's time to update this part of the extension on a large scale, don't you think? Would be consistency to write to you on email, if you don't mind.

sgkoishi commented 3 years ago

Well technically those belong to Blizzard but they should be open to the community :) ~~Just wondering, did you grab the names of Book of Heroes and Year of the Dragon manually? I didn't see those translations in the dbf resource~~

TheMrKochan commented 3 years ago

@sgkoishi something manually through the translator, something from the official site, only changing the region (this is about the year of the Dragon). Regarding the book of heroes, Yes, everything is manual. I have no experience in programming and a complete zero in this, but I decided to help with what I could :)

TheMrKochan commented 3 years ago

I thought it would be easier to identify the pack than " Standard pack class name". Oh, you've made additional changes, I'll have to "steal" your code again. Damn...

sgkoishi commented 3 years ago

I thought it would be easier to identify the pack than " Standard pack class name". Oh, you've made additional changes, I'll have to "steal" your code again. Damn...

I extract the translations from the game itself. For those "Standard" packs they were actually unnamed in the game data, finding it through the store page takes much more time so I just use their description instead.

TheMrKochan commented 3 years ago

If not a secret: how do you do this? I want to try it, hehe

sgkoishi commented 3 years ago

If not a secret: how do you do this? I want to try it, hehe

Not quite sure if that should be a secret but it probably violates EULA: Google for some tools and targets the file called dbf.unity3d (inside Hearthstone directory).

TheMrKochan commented 3 years ago

Updated for new expansion

TheMrKochan commented 3 years ago

Hello @MGK82 ! When do you plan to update the extension?

Volkai7 commented 3 years ago

Found some more pack ID-name connections, is this the right place to put them?

Pack ID : Set 643 -- GOLDEN Madness at the Darkmoon Faire pack "Golden Pack" -- Hunter Class pack 545 -- Mage Class pack 498 -- Year of the Dragon pack

Volkai7 commented 3 years ago

MORE Pack IDs: Forged in the Barrens -- 553 GOLDEN Forged in the Barrens -- 686 Year of the Phoenix -- 688 Paladin Class -- 632 Warrior Class -- 633 Priest Class -- 634 Rogue Class -- 635

TheMrKochan commented 3 years ago

@Volkai7 Hi, these positions are already in the file, it remains to wait for the author of the extension and he will update it.

Volkai7 commented 3 years ago

Oh! ALso 603 is GOLDEN Scholomance Academy

Volkai7 commented 3 years ago

@Volkai7 Hi, these positions are already in the file, it remains to wait for the author of the extension and he will update it.

Glad to hear it! I didn't know where to look so I just started finding the packs in history that had an ID and identifying what they were.

TheMrKochan commented 3 years ago

Glad to hear it! I didn't know where to look so I just started finding the packs in history that had an ID and identifying what they were.

check my profile, may be find some interesting

TheMrKochan commented 3 years ago

Here is all available pack names at current time

sgkoishi commented 3 years ago

I've updated some pack names in my repo.

Rename Year of the ___ to Year of the ___ Card Pack
Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.) (no druid or warlock yet, but everything else is 100% same as in-game)

TheMrKochan commented 3 years ago

I've updated some pack names in my repo.

Rename Year of the ___ to Year of the ___ Card Pack

Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.) (no druid or warlock yet, but everything else is 100% same as in-game)

Hi! Please tell me what are the advantages or differences from the main build?

sgkoishi commented 3 years ago

I've updated some pack names in my repo.

Rename Year of the ___ to Year of the ___ Card Pack

Use official translations for class packs (Mage Card Pack, Paladin Card Pack, etc.) (no druid or warlock yet, but everything else is 100% same as in-game)

Hi! Please tell me what are the advantages or differences from the main build?

Comparing to your version: all year-or-the-something and all class packs translations from in-game reward list https://gist.github.com/sgkoishi/d276fe3e770b9078504bcb03c3eb11e5/revisions

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

TheMrKochan commented 3 years ago

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

I would like to switch to your build, but I do not yet understand what exactly you have changed compared to the original extension from MGK82

sgkoishi commented 3 years ago

I'm not sure if you machine translate some names or not, but at least for zhTW and zhCN, you version is like Pack Hunter and mine is Hunter Card Pack

I would like to switch to your build, but I do not yet understand what exactly you have changed compared to the original extension from MGK82

If you mean by the codebase:

I change those hard-coded dictionaries to a JSON file that will be loaded dynamically (be97beb402a12dea39e94ba71b0cfa359fda5541)
- PackHistorian/Resources/packs.json
- PackHistorian/View/PackNameConverter.cs
- PackHistorian/PackTracker.csproj
```
<ItemGroup>
<EmbeddedResource Include="Resources\packs.json" />
</ItemGroup>
```
Add CI, if you change something in the browser, the GitHub will build a version automatically (be97beb402a12dea39e94ba71b0cfa359fda5541)
- PackHistorian/PackTracker.csproj (the rest part except 3 lines mentioned earlier)
- .github/workflows/build.yml
Backwards compatibility to HDT 1.14.4 and prior (in theory, not tested)
- PackHistorian/PackWatcher.cs
Apply code style
- Just changing indentation, spacing, formatting, new lines, linebreaks etc.
- You can safely ignore this change

TheMrKochan commented 3 years ago

@sgkoishi I translate some program items manually into Russian, in your version I will be able to do this without the same problems as it is happening now?

sgkoishi commented 3 years ago

@sgkoishi I translate some program items manually into Russian, in your version I will be able to do this without the same problems as it is happening now?

I'm not sure what problem it is - but those new texts I'm using are extracted from the game (REWARD_LIST) and should match each other

TheMrKochan commented 3 years ago

I mean the xaml files in the Controls directory

sgkoishi commented 3 years ago

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

TheMrKochan commented 3 years ago

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

No, thank you, I have already figured out and translated only for myself the main points of the interface)

TheMrKochan commented 3 years ago

I mean the xaml files in the Controls directory

Still not sure what the problem is. Do you need help translating the GUI of this plugin?

Promise that you will not abandon the updates of this extension, you will support it and PERHAPS add some nice features (for example, manually adding the contents of packages. I've seen this somewhere in forks) and I'm all yours :D

MGK82 / PackTracker

Grand Update PackNameConverter.cs #39