search

MGlolenstine / gtk4-cross

A Docker container for cross-compiling gtk4 programs to Windows.
57 stars 12 forks source link

`package` does not actually zip anything #32

Open faern opened 4 months ago

faern commented 4 months ago

The documentation states that:

Then run build to build the project and package to package it into a zip file. package.zip will be present in your project directory.

But the actual zipping was removed in 1ebf590a2e1a6d849affc6068caefe068a7246e2. Now package does not seem to create package.zip any longer. I'm not sure if it was a mistake to remove it (and should be added back), or if intentional (and the documentation should be fixed)

The zip package is still installed at the beginning of the container definition. If zipping is no longer desired, it could maybe be removed?

MGlolenstine commented 4 months ago

You are indeed correct. An update of README is needed.

The change was debated here and you can still zip it, if that's needed.