search

MGlolenstine / gtk4-cross

A Docker container for cross-compiling gtk4 programs to Windows.
57 stars 12 forks source link

Icons missing in GTK File Chooser Dialogue #7

Closed 13hannes11 closed 2 years ago

13hannes11 commented 2 years ago

I am not sure how the issue originates but in my application the GTK File Chooser Dialogue is slow and missing icons on the windows version packaged with this image.

MGlolenstine commented 2 years ago

Icons aren't packaged into the package.zip by default. You will have to change the package.sh script to copy the theme you want included into the package/ folder before you archive it.

rust-crosscompile does it like this for GTK3. I was thinking about optimising it and never fully implemented it. I'll take a look at porting the GTK3 code later today, if that's something you need.

File Chooser Dialog could be slow due to it missing icons.

13hannes11 commented 2 years ago

Do you think this could be added here and configured as an optional part of the script?

Alternatively a second script like package_with_icons.sh could be included to allow for that use case.

What do you think?

MGlolenstine commented 2 years ago

I would love to include the icons by default, as most of the programs make no sense when packaged without them. However, I don't want to package 250MB (probably exaggerating) of icons and theme, if only a small portion of it is used.

I still need to think about it, but I do think splitting it into two different scripts would be a good option for now.

13hannes11 commented 2 years ago

I added the changes to try it out and the size of package.zip increased from ~15 mb to ~30 mb

MGlolenstine commented 2 years ago

You contribution is now present in the new containers.

Thank you! (closing this as solved)