search

MHH-RCUG / scrnaseq_app

UNDER DEVELOPMENT: Shiny app for visualisation of scRNASeq data
2 stars 4 forks source link

Select genes options #68

Open kosankem opened 3 years ago

kosankem commented 3 years ago

It is possible to select genes manually and simultanously via list. The manually selected genes, however, are the only ones that are than displayed in the end. It would be more intuitive if the selecetion of one of the selection methods would clear the fields of the other methods as it is not possible to use them thogether.

Amendment: After some more trying, I noticed that what I described above is actually the case. However, I was able to miss that I need to press the select list button. I can imagine that the same might happen to others as well. Is it possible to chose simply via the pull down menu. That would be more intuitive as for the two other selection methods one does not need to press an extra button.

kosankem commented 3 years ago

Should we include a limit of gene input to avoid too extensive processing time?

kosankem commented 3 years ago

In case that no gene could be extracted from the uploaded excel file, a warning might be helpful.

mariusrueve commented 3 years ago

I added a warning when the excel file is empty (2b80250b3fa78a1e802cbcb8db9a6adbd2464e1c).

The "Select List" is a workaround and made the implementation of this feature a lot easier. In order to archive the goal with a simple drow down menu, I have to restructure the code. I will try to fix this, because, as you have said, it is way more intuitive.

What do you think is a reasonable limit for the gene selection? I can't estimate how many genes are enough

kosankem commented 3 years ago

I have the impression that the numbers of genes that are displayed in heatmaps are often 50, 100, 300, or 500. So, maybe 500 might be a reasonable limit.