search

MHKiT-Software / MHKiT-MATLAB

MHKiT-MATLAB provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
15 stars 23 forks source link

read NetCDF file #104

Closed kchong75 closed 1 year ago

kchong75 commented 1 year ago

created read netcdf file and helper functions in utils/ updated utils_test, included testing NetCDF files

rpauly18 commented 1 year ago

Note: update version requirements to 2021b

rpauly18 commented 1 year ago

On quick comment, please decrease the number of .nc files you have in the "example_ncfiles" folder. About 4 or 5 .nc files should be enough. Choose ones of a variety of types. To remove the rest, use "git rm" in your local and commit the changes to remove from git tracking. We try to not have too many data files in the repository

rpauly18 commented 1 year ago

I could have missed it, but it does not look like "read_nc_file_var" is tested anywhere. If that is the case, please add a test for that function.

rpauly18 commented 1 year ago

Since read_nc_file_group is used regardless of if the netCDF file has groups or not, I would change the name of the function to "read_nc_file" or similar.