search

MHKiT-Software / MHKiT-MATLAB

MHKiT-MATLAB provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
15 stars 23 forks source link

Add `method` option to `surface_elevation` #126

Closed simmsa closed 1 month ago

simmsa commented 2 months ago

In MHKiT-Python #250 a method option was added to wave.resource.surface_elevation. This exposes that option to the MHKiT-MATLAB user.

simmsa commented 2 months ago

List of changes:

  1. Add method option to surface elevation
  2. Add test to to verify that the method option gets passed to python and the results for each method match each other
  3. Get tests working using findings from delft-3d-io branch
  4. Update plugin version to 0.4.1.1
  5. Update binary
simmsa commented 1 month ago

@rpauly18 or @hivanov-nrel, this is ready for review when either of you have time. I would like to get this into master before we merge Delft3D functionality.

simmsa commented 1 month ago

@rpauly18, thanks for reviewing! The new version of MHKiT-Python is introducing some new bugs for us. I am tracking them in #130. My best guess is your test failures are related similar to the ones introduced by v0.8.0. I am going to go ahead and merge this.