search

MHKiT-Software / MHKiT-MATLAB

MHKiT-MATLAB provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
15 stars 23 forks source link

Addressing issue #65 tidal ebb and flood plots for Matlab #73

Closed Alex-McVey closed 2 years ago

Alex-McVey commented 2 years ago

2 new function files to control the plotting. Also updated tidal example problem to demonstrate their use. I did not seem to have access to the mhkit_0.3.prj file and was thus unable to update the mhkit toolbox to include the new function files.

rpauly18 commented 2 years ago

@Alex-McVey as I dive into reviewing this PR, one thing you can begin working on is developing tests for the new functions. These tests can be added to Tidal_TestResource.m. Examples of how to set up the tests can also be found in that file.

rpauly18 commented 2 years ago

@Alex-McVey can you add me as a contributor to your MHKiT-Matlab repo? I have a couple minor updates I want to push.

rpauly18 commented 2 years ago

This was a great PR. Only changes I made were to pull down the latest version of Master (somehow Develop ended up diverging from Master) and I updated the function descriptions. I will finish review once tests are added.

One other edit you should make is to export the tidal example notebook to HTML and save then commit. This will allow the latest version of the notebook to show up on the documentation site.