search

MHKiT-Software / MHKiT-MATLAB

MHKiT-MATLAB provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
15 stars 23 forks source link

Fix MacOS-Python 3.8 Unit Test Failures #92

Closed H0R5E closed 2 years ago

H0R5E commented 2 years ago

This PR fixes the test failures occurring on the GitHub Actions runners using MacOS and Python 3.8. It seems like there was a race condition occurring, evident from a successful test here versus an unsuccessful one here, with both having exactly the same configuration.

So, I had the idea to try and running the InProcess Python mode for MacOS to see if it would reveal what was triggering the race but in doing so it seems like all the tests passed fine. Therefore, I propose to only use the OutOfProcess Python mode for the Linux tests.

I had originally thought that this was a dependency fault with MHKiT-Software/MHKiT-Python, so I have also added a CI step for testing MHKiT-Python conditional on the MHKit-MATLAB tests failing. It is not actually useful in this case, but might be useful in the future, so I have left it there. The only downside it that the MHKiT-Python tests are rather inefficient.

Note that timeout failures are still occurring, which is causing the updated tests to fail sporadically.

Fixes #90