MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
50 stars 45 forks source link

XML reader is skipping lines #147

Closed Matthew-Boyd closed 1 year ago

Matthew-Boyd commented 2 years ago

The XML reader '_xml_to_dataframe()' in noaa.py is skipping every other line of data as it is assuming every line is duplicated (indicated by the TODO statements on lines 146 and 154). This however is at least not the case for the test 'test_request_noaa_data()' in noaa.py. Therefore, half the data is being omitted in the output dataframe.

Specifically, the response from the noaa query includes data at times: 00:04 00:10 00:28 00:34 00:46 ...

but the output from the XML reader only includes the times: 00:04 00:28 00:46 ...