search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

DOLfYN source code #169

Closed jmcvey3 closed 1 year ago

jmcvey3 commented 2 years ago

Integrated source code with latest bugfixes. Will need to update jupyter notebook documentation links once docs are completed.

jmcvey3 commented 2 years ago

@ssolson Did some renaming and reorganization to hopefully make the analysis functions easier to understand. Top level functions are located in velocity.py, mid-level in binned.py, and base-level in the "tools" folder. I would expect most users to utilize the top-level functions, but the public functions in the lower two levels are useful for python-knowledgeable users.

We had also discussed creating an issue to reassign functions that exist in other packages (like scipy) as I was under the impression that generic statistical calculations like coherence, phase-angle and auto/cross-covariance would exist in other packages. Apparently they do not.

jmcvey3 commented 2 years ago

Failures appears to be new bugs in the netCDF4 1.6.0 release

ssolson commented 1 year ago

Hey James I documented the netcdf issue in #177. As far as I can tell this is not a Dolfyn issue. Can you merge the latest development branch in this PR as a temporary fix. I will follow up on the netCDF issue in a separate PR.

Also can you edit the merge to occur to the Develop branch instead of the master?

ssolson commented 1 year ago

Hey James I have been looking into this more and it appears that it is actually the Dolfyn xarray .to_netcdf method which is breaking the UNIX tests for MHKiT which you can checkout on #181. I am going to be poking around to see if I can fix it but if you get a chance to take a quick stab at it I would appreciate your thoughts on the problem and could run with any ideas you may have to fix it.

Based on our last conversation/ review of Dolfyn is this PR ready to go?

jmcvey3 commented 1 year ago

Hey James I have been looking into this more and it appears that it is actually the Dolfyn xarray .to_netcdf method which is breaking the UNIX tests for MHKiT which you can checkout on #181. I am going to be poking around to see if I can fix it but if you get a chance to take a quick stab at it I would appreciate your thoughts on the problem and could run with any ideas you may have to fix it.

Based on our last conversation/ review of Dolfyn is this PR ready to go?

It is ready to go. I haven't been able to replicate this error yet, but I'll keep searching for a solution

jmcvey3 commented 1 year ago

Hey James I have been looking into this more and it appears that it is actually the Dolfyn xarray .to_netcdf method which is breaking the UNIX tests for MHKiT which you can checkout on #181. I am going to be poking around to see if I can fix it but if you get a chance to take a quick stab at it I would appreciate your thoughts on the problem and could run with any ideas you may have to fix it. Based on our last conversation/ review of Dolfyn is this PR ready to go?

It is ready to go. I haven't been able to replicate this error yet, but I'll keep searching for a solution

@ssolson Apparently recreating the test file fixes that issue #181