Adding Limited Xarray Support in MHKiT - Githubissues

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.

https://mhkit-software.github.io/MHKiT/

BSD 3-Clause "New" or "Revised" License

47 stars 45 forks source link

Adding Limited Xarray Support in MHKiT #170

Closed Alex-McVey closed 1 year ago

Alex-McVey commented 2 years ago

Current idea behind implementation is:

for all functions that get data and return it to the user, there will be a flag for xarray
for all functions that take data as an input, there will be a decorator that converts data

ssolson commented 1 year ago

Hey Alex. I fixed some commit history issues with the Development branch today so that these PRs will only show the files you changed.

To get this to show up correctly in the PR could I ask that in the top you click the "Edit" button then switch the branch to master and then repeat that process to set the merge back to Develop?

By doing this it should remove from this PR all the WDRT/ Dolfyn commits and more that appear as part of the commit history in this PR.

Alex-McVey commented 1 year ago

This PR is ready for review. As discussed I reset the changes in wave/resources.py so that the only changes in this PR are to functions that fetch data for the users.

ssolson commented 1 year ago

@Alex-McVey I opened a PR on your branch to merge the changes to ndbc (Resolve the conflicts as shown in the message below)so the tests can run for this PR.

ssolson commented 1 year ago

Hey Alex my PR is still open on your branch. I pushed some changes that fix some bugs around the import statements of utils. I also got the branch up to date with the current Development branch. If you review and merge my changes we should be able to run the tests here to make sure everything is passing. I will be out of the office until the 6th of September but I'll catch back up then.

ssolson commented 1 year ago

@ssolson your changes look good to me. I can't quite tell from this view if you changed the docstrings or if I still need to do it.

The code shown on your branch will always show the code exactly as it is being requested to merge if you need to check. https://github.com/Alex-McVey/MHKiT-Python/tree/iss78

ssolson commented 1 year ago

@Alex-McVey I am not seeing the tests for this PR. Can you push up the tests you wrote? I think we need to add the functionality as an example to at least one of the examples that we can point people to on the PRs use.

akeeste commented 1 year ago

This feature is superseded by #221 will continue there