search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Trasect comparison #199

Closed browniea closed 1 year ago

browniea commented 1 year ago

Issue #188

I added an example notebook for the Delft_3d transect of Tanana.

ssolson commented 1 year ago

Emily we have updated the testing to fix issues on the CI end. Could you merge the latest Develop into your branch to check your PR (same for #190)?

ssolson commented 1 year ago

For Thursday

  1. Contour plot of Experimental Data
  2. Contour plot of D3D
  3. Contour plot of L1 norm difference
  4. Contour plot of L2 Difference
  5. On plots 3 and 4 a point indicating the max error (L infinty)
ssolson commented 1 year ago

For Tuesday 11/22

  1. cleaned experimental data contour
  2. comparison plots from the previous post

side quest to look into D3D bathymetry data and if we can get plot/ simulation closer to the city side

browniea commented 1 year ago

@ssolson

I tried using contourf instead of tricontour and I got the error "setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimension. The detected shape was (2,) + inhomogeneous part." I double checked that in inputs to be the same size and regularly spaced.

I also ran into some problems with the latest Delft3D update. I couldn't open the Tanana model. I'll look into this more after I'm back from break. For now, I'll use the previous plots for the paper.

ssolson commented 1 year ago

@browniea the example is no longer in the folder. I think you renamed the file and did not add the new file name to your commit.

ssolson commented 1 year ago

@browniea The dataset does not seem to be reading in the same for me. The data does not have a lattitude_gps key. Any idea what is going on here? image

ssolson commented 1 year ago

Hey @jmcvey3 could you look at the issue above with the lattitude_gps error? @browniea let me know she is using a custom Dolfyn version you sent her to process the Teledyne data. We thought this would be included in the recent Dolfyn merge.

What do we need to do to get this example working for the public?