MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

KDE Method for environmental contours #202

Closed d-andrievskaia closed 1 year ago

d-andrievskaia commented 1 year ago

My question is regarding methodology used for the environmental contours’ calculation, particularly with KDE method. So the concern is that, when plotting contours for different return periods (1, 5, 10, 100 - years), these contours are getting closer and closer to each other with an increase in return period, so for the small bandwidths the difference between contours becomes almost indistinguishable (I attach a couple of pics for an illustration). For other methods this tendency is also present, yet the contours are not that ‘tightly’ placed. Can such behaviour be considered as ‘normal’/expected? leucate_KDE_all_bw-03 leucate_KDE_all_bw-07

ssolson commented 1 year ago

Hello @d-andrievskaia and thanks for your interest in MHKiT. I cannot provide detailed insight into this specific question but as @ryancoe mentioned by email I believe he has some articles he can share with you.

ryancoe commented 1 year ago

There's a good description of the KDE contours provided in the following papers:

As you point out, this behavior of contours for increasing return periods being more tightly spaced is generally apparent in most (all?) contours, so yes, I would say this behavior is expected. The fact that the KDE distributions have relatively shorter tails when compared with other methods (and, by extension, the contours for increasing periods of return are more closely spaced) is just the nature of the contour, but not a bug. I believe you will find that if you increase the bandwidth you will get a larger spacing between the contours for different return periods (see the OCEANS paper above for some discussion on this). Note that the OCEANS paper focuses partially on adaptive bandwidth KDEs, but we subsequently put the adaptive bandwidth approach aside in favor of a fixed bandwidth (see pg. 8 of JMSE paper).

https://github.com/MHKiT-Software/MHKiT-Python/blob/21ff3a24c37c528b3e2b087a486fc1b80a932a16/mhkit/wave/contours.py#L50-L52

Hope this helps! If @aubreyeckert is able to add/correct anything I've said, that would be most welcome ;)

d-andrievskaia commented 1 year ago

Hello @ryancoe, thank you for your response and for the papers! I indeed noticed that with an increase in bandwidth we get a larger spacing between the contours for different return periods. Just had doubts about the nature of this tendency.

Thank you again!