search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Issue Accessing Hindcast Data at a specified location #203

Closed ssolson closed 1 year ago

ssolson commented 1 year ago

We cannot access direction wave spectrum data from the hindcast dataset hosted on NREL's HSDS. This issue first appeared in #194 where we merged a version of the MHKiT CI which does not check hindcast tests in order to close out a backlog of PRs.

The issue was brought to the nrel-rex team where we determined:

  1. Neither of us seem to be able to pull the full data volume from that dataset
  2. The errors are being raised by h5pyd, not rex, and appear to be saying "no data has been returned"
  3. Smaller datasets or a slice of the spectrum dataset are retrieved just fine
  4. The original code requesting the spectrum data in dataframe works fine when pointing to the Eagle datasets

From this diagnosis I have reached out to the nrel-developer network in a new issue here: https://github.com/NREL/developer.nrel.gov/issues/285

ssolson commented 1 year ago

Speaking to the NREL developer network in the linked issue above they are not sure how our call was ever working.

The path forward is to write a wrapper and hit the API multiple times. I will get a draft PR of this up soon.

ssolson commented 1 year ago

Issue was resolved by #211