search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Bug Fix: Averaging histogram bin and wave energy #205

Closed ssolson closed 1 year ago

ssolson commented 1 year ago

Addresses issue #204 plus minor formatting updates to wave/graphics.py

ssolson commented 1 year ago

@cmichelenstrofer would you mind taking a look at this PR? @akeeste is OOO.

cmichelenstrofer commented 1 year ago

@ssolson I can't think of any way of adding a test since the output is a figure. How can we catch this type of things in the future?

ssolson commented 1 year ago

@ssolson I can't think of any way of adding a test since the output is a figure. How can we catch this type of things in the future?

Off the top of my head, we would separate out the calculation of the QoIs and the plotting into multiple functions. Given the other PRs/Issues I would rank this as a lower priority but something to consider as a "Good first Issue".