Closed jmcvey3 closed 1 year ago
James thank you for submitting the PR. To start the review I have a couple of questions about large log files:
examples/data/dolfyn/test_data/AWAC_test01.log
examples/data/dolfyn/test_data/vector_data_imu01.log
examples/data/dolfyn/test_data/RDI_withBT.log
These add about 11 MB of log data. Is there a way we could reduce these log file sizes such as checking against a smaller dataset (and therefore a smaller associated log file), checking only a portion of the produced log, or mocking the data somehow?
James thank you for submitting the PR. To start the review I have a couple of questions about large log files:
- 1.16 MB
examples/data/dolfyn/test_data/AWAC_test01.log
- 6.74 MB
examples/data/dolfyn/test_data/vector_data_imu01.log
- 3.05 MB
examples/data/dolfyn/test_data/RDI_withBT.log
These add about 11 MB of log data. Is there a way we could reduce these log file sizes such as checking against a smaller dataset (and therefore a smaller associated log file), checking only a portion of the produced log, or mocking the data somehow?
Good point, yes I can reduce the size of these.
@ssolson In case I hadn't mentioned it, I think this PR should now be covered. I'll need to update the docs, but I believe it's easiest to wait until this is merged into Develop?
Thanks James. I'm going to merge into Develop. Please update the Docs as you mentioned.
A number of updates: