MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Dolfyn updates #212

Closed jmcvey3 closed 1 year ago

jmcvey3 commented 1 year ago

A number of updates:

  1. Fixes for TRDI reader: #182, #206, #207
  2. Fix for VMDAS files with interleaved pings
  3. Motion correction for duty-cycled ADVs
  4. lncorporated logging module for into reader debuggers
  5. Ensure datatypes are saved as float32 instead of float64 to reduce filesize
  6. Added another ADCP clean function
  7. Updated docstrings to mhkit formatting
  8. Other minor bugfixes
ssolson commented 1 year ago

James thank you for submitting the PR. To start the review I have a couple of questions about large log files:

  1. 1.16 MB examples/data/dolfyn/test_data/AWAC_test01.log
  2. 6.74 MB examples/data/dolfyn/test_data/vector_data_imu01.log
  3. 3.05 MB examples/data/dolfyn/test_data/RDI_withBT.log

These add about 11 MB of log data. Is there a way we could reduce these log file sizes such as checking against a smaller dataset (and therefore a smaller associated log file), checking only a portion of the produced log, or mocking the data somehow?

jmcvey3 commented 1 year ago

James thank you for submitting the PR. To start the review I have a couple of questions about large log files:

  1. 1.16 MB examples/data/dolfyn/test_data/AWAC_test01.log
  2. 6.74 MB examples/data/dolfyn/test_data/vector_data_imu01.log
  3. 3.05 MB examples/data/dolfyn/test_data/RDI_withBT.log

These add about 11 MB of log data. Is there a way we could reduce these log file sizes such as checking against a smaller dataset (and therefore a smaller associated log file), checking only a portion of the produced log, or mocking the data somehow?

Good point, yes I can reduce the size of these.

jmcvey3 commented 1 year ago

@ssolson In case I hadn't mentioned it, I think this PR should now be covered. I'll need to update the docs, but I believe it's easiest to wait until this is merged into Develop?

ssolson commented 1 year ago

Thanks James. I'm going to merge into Develop. Please update the Docs as you mentioned.