search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Automatic optimal threshold for peaks-over-threshold method #214

Closed cmichelenstrofer closed 9 months ago

cmichelenstrofer commented 1 year ago

Automatic threshold for peaks-over-threshold developed by Vince Neary and Seongho Ahn.

cmichelenstrofer commented 1 year ago

FYI @Graham-EGI @mbruggs

cmichelenstrofer commented 1 year ago

MHKiT already has a peaks-over-threshold method, which takes in threshold as one of the inputs. This method here is to automatically calculate the "best" threshold. It is from a paper by Vince and Seongho:

Neary, V. S., S. Ahn, B. E. Seng, M. N. Allahdadi, T. Wang, Z. Yang and R. He (2020). "Characterization of Extreme Wave Conditions for Wave Energy Converter Design and Project Risk Assessment.” J. Mar. Sci. Eng. 2020, 8(4), 289; https://doi.org/10.3390/jmse8040289.

They had it in Matlab and I converted it to Python here.

cmichelenstrofer commented 1 year ago

added the check for independent storms. But results are not matching the original Matlab code. Will debug later.

ssolson commented 1 year ago

Hey @cmichelenstrofer I wanted to check in on if you had any offline progress on this PR?

cmichelenstrofer commented 1 year ago

@ssolson No, I really need to to get back to it and wrap it up. I'll try to find some time to do that in the next couple of weeks.

ssolson commented 9 months ago

Hey @cmichelenstrofer I wanted to check in on this PR.

I was going to try to sum up your changes and look at taking it over or closing it due to inactivity but the diff in on 137 files and I'm not sure exactly what you changed (without more effort than simply asking).

How close is the work that have done to completion and could you point out exactly what you added?

cmichelenstrofer commented 9 months ago

This branch got messed up real bad. will open an new PR.