search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Fix type for return_year in extreme.return_year_value #225

Closed mbruggs closed 1 year ago

mbruggs commented 1 year ago

In an oversight in merging #193 the docstring was updated for the type of return_year in return_year_value but the corresponding assertion was not.

Tests for the types of the two input parameters have been added to try to avoid a simular situation occuring the future.

mbruggs commented 1 year ago

Sorry about this, my mistake in the initial PR. I found it when trying to integrate v0.6.0 into a project. Is there a 'hot-fix' procedure that would mean a v0.6.1 would be possible with just this change (or any others that fix bugs)?

mbruggs commented 1 year ago

Looks like there are quite a few test failures but they don't appear to be related to this code change.

ssolson commented 1 year ago

No worries @mbruggs we can tag a new release with this change. Thank you for posting this new PR.

I am looking into the other failures. At first glance, It looks like matplotlib updated.

mbruggs commented 1 year ago

Thanks @ssolson!

ssolson commented 1 year ago

226 should fix the issues with the matplotlib update

ssolson commented 1 year ago

@mbruggs it is showing that you are trying to change 190 files currently.

Can you resubmit this PR using the latest version of develop as your HEAD so that we are sure we are only changing what we intend to?

ssolson commented 1 year ago

Okay @mbruggs I fixed the issues causing the tests to fail by merging #226 . If you pull the latest develop branch everything should pass.

mbruggs commented 1 year ago

Thanks for fixing the matplotlib issue so quickly, @ssolson. It seems to have fixed the tests except the hindcast ones which seem to be hanging (I couldn't find a way to stop them).

Branch has been rebased so now only showing the files that have actually been changed.