Closed mbruggs closed 8 months ago
@mbruggs this looks like a perfect fit for MHKiT. I would recommend this for inclusion in MHKiT and could work with you to help develop examples and tests but could not lead the design. I think an example of the functions in a new example or as an expansion of the previous would help me understand better how this fits into MHKiT.
Resolved by #252
Describe the bug:
At present an upcrossing analysis is performed in the
loads.extreme.global_peaks
function. In that case the maximum value between up crossings is returned.I had a case today where I wanted to find the heights of the individual waves in a time series. To do this, I pulled the zero crossing code from
global_peaks
and modified it to the belowIt would be nice to pull out the zero crossing part to a helper function and provide some new functions in the
wave
module forglobal_peaks
is now)What does the MHKit team think about this?
Happy to contribute the change when I have a moment.