search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Package Requirements & Python version 10, 11 #240

Closed ssolson closed 8 months ago

ssolson commented 1 year ago

This PR adds testing support for Python 3.10 and 3.11 and removes all upper bound on required package versions such that users can work with the newest versions of all required packages.

Additionally this PR will now only run on ubuntu on pulls to develop and will run windows, macOS, and ubuntu on pulls to master. This reduces runtime by ~15 minutes for development PRs. To make this work a new job was added set-os which sets the os matrix based on which branch the PR is made against.

Most changes did not require changing the module source code. To update to the latest pandas:

image

ssolson commented 8 months ago

Pecos has merged a fix to master causing the error seen in the current build. Specifically the error is from pandas index method deprecation which replaced is_montonic with is_monotinic_increasing (or decreasing) and will soon release an update to pypi which will allow MHKiT to pass tests with the most recent pandas version.

https://github.com/sandialabs/pecos/issues/76

ssolson commented 8 months ago

@akeeste this PR is ready for review.

One discussion point I would suggest adding would be to only test ubuntu on pulls to the dev branch and then test windows and mac on pull to the master branch. Doing so would reduce testing time from ~30 minutes to ~15 minutes.

image

Would you be opposed or have any concerns with this testing setup?

ssolson commented 8 months ago

@akeeste I believe I have addressed your changes as well as added the only ubuntu on pulls to develop. Please, give it a review and lmk what you think.