search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Nortek Signature Reader Altimeter Update #280

Closed jmcvey3 closed 5 months ago

jmcvey3 commented 7 months ago

PR containing fixes for Issue #277 & #284

ssolson commented 7 months ago

@jmcvey3 thanks for putting this fix together! Did you see the changes caused a couple errors in the dolfyn tests?

jmcvey3 commented 6 months ago

@ssolson Yes, I wanted to make sure the issue was solved before going through and fixing the tests. I've updated the tests now that I've gotten the affirmative that the issue was resolved.

I also threw in a fix for a bug where netcdf compression wasn't working properly. The prior code would only work with netCDF4 < 1.6.0, which isn't compatible with python 3.11.

jmcvey3 commented 5 months ago

Thank @jmcvey3 this is looking pretty much done. I only really spotted a couple of questions in the new dictionaries you added.

Could you briefly document here what you updated in all the bin files?

Given new test data, I found that the altimeter data wasn't being labeled properly versus what Nortek software was outputting. These changes primarily handle those metadata updates, and because the metadata changes, the test files also change.