MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Convert power module to xarray #282

Closed akeeste closed 5 months ago

akeeste commented 6 months ago

power.quality

power.characteristics

TODO

akeeste commented 5 months ago

@ssolson Thanks for the review. I went through your comments and resolved them, which were primarily on adding parameter validation and doc strings where missing. I reverted the test to recalculate the answer as described above, and double-checked that the power notebook runs. I think the only outstanding item is to ensure that the THCD calculation is not missing anything.