search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Add capability to read ADCP dual profile configurations #289

Closed jmcvey3 closed 3 months ago

jmcvey3 commented 4 months ago

Fix for #287, which is data from a dual profiling ADCP taking a large combination of burst and average measurements.

ssolson commented 4 months ago

@jmcvey3 as of #281 all MHKiT code must adhere to black formatting.

You simply need to install the package and run black .

You can also integrate it into your IDE such as VSCode or create a pre-commit hook as detailed in the MHKiT README.

jmcvey3 commented 4 months ago

Will fix tests when I know everything is functional

jmcvey3 commented 4 months ago

@ssolson Can you see if you can format the two files this test says are failing? Running black . makes no further changes beyond commit 7fa66b0

ssolson commented 4 months ago

@ssolson Can you see if you can format the two files this test says are failing? Running black . makes no further changes beyond commit 7fa66b0

The error says to install black[jupyter] I'm not sure why since these are not ipynb but can you try that?

...ohh wait that is just a warning of sorts... I will try tomorrow.

One other thing to check is that your black formatter is the latest version.

image

jmcvey3 commented 4 months ago

@ssolson Can you see if you can format the two files this test says are failing? Running black . makes no further changes beyond commit 7fa66b0

The error says to install black[jupyter] I'm not sure why since these are not ipynb but can you try that?

...ohh wait that is just a warning of sorts... I will try tomorrow.

One other thing to check is that your black formatter is the latest version.

image

Hmm, just uninstalled the pip version and installed it from conda. Still no luck.

ssolson commented 4 months ago

@jmcvey3 I upgraded my black using pip pip install black --upgrade

I was able to then update using black .

I would try the pip version since releases are faster vs conda and our tests use a pip install.

If you don't care about that I pushed to ssolson dual_profile which you can pull from to just knock this task out.

image

jmcvey3 commented 4 months ago

@willcoxe Is it alright with you if we use the 1 Mb file for a software test? I will try to trim it down to the minimum file size necessary to check all the code I updated.

willcoxe commented 4 months ago

I don't own the file so I can't make that call I'm afraid. It's eventually intended to be published with a doi by the uni/research group who own it.

ssolson commented 4 months ago

@jmcvey3 is this PR ready for review?