search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Reading ad2cp-file with dolfyn.read gives completely wrong temperature values #298

Closed stinawahlgren closed 3 months ago

stinawahlgren commented 3 months ago

I'm using MHKiT (version 0.7.0) to open an ad2cp-file from Nortek Signature1000 in python, and noticed that the temperature values are completely off. They range between 653.42 and 653.58. Temperature values are normal when I convert the ad2cp-file to a mat-file using Nortek's own software.

Happy to provide more details if needed. Thank you for an overall great software!

ssolson commented 3 months ago

Hey @stinawahlgren thank you for your interest in MHKiT and bringing this to our attention.

Is there anyway you could provide us with the data or a subset of the data that we can use to reproduce this issue?

jmcvey3 commented 3 months ago

Ah, the water temperature is below 0, isn't it?

stinawahlgren commented 3 months ago

Ah, the water temperature is below 0, isn't it?

Yes, that is correct. Life of a polar scientist :)

ssolson commented 3 months ago

@stinawahlgren could you pull PR #299 (jmcvey3 branch temp_fix) and let us know if that resolves your issue?

stinawahlgren commented 3 months ago

@stinawahlgren could you pull PR #299 (jmcvey3 branch temp_fix) and let us know if that resolves your issue?

Yep, this resolves my issue, temperatures are now correct.

Thank you for such a quick handling of the issue!

ssolson commented 3 months ago

Thank you for helping us improve the software! Please let us know is you run into any future issues and good luck in your research.