search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Fix hanging Hindcast tests #311

Closed ssolson closed 2 months ago

ssolson commented 2 months ago

This PR addresses 2 issues with the hindcast tests:

  1. On PRs tests were only being run on changes to hindcast test files.
    • Fixed to run on changes to hindcast test and module files.
  2. The prepare cache job was failing due to 6 hour job limit.
    • Fixed by breaking out each hindcast cache test into its own job.

Additionally this PR updates action packages to the latest version where possible.

ssolson commented 2 months ago

Okay we are for sure hitting a 6 hour limit of the wind tests.

image

Running just the wind_hindcast tests locally it takes 4 hours and 22 minutes. Which is pretty insane amount of time. I think if I break these out into their own jobs I could get 6 hours per job,

image

ssolson commented 2 months ago

Okay great the hindcast jobs now run separate which should fix the 6 hour issue. The new job flow looks as follows: image

ssolson commented 2 months ago

Okay great new test structure is working. Just need to check these final adjustments to make sure the check changes on multiple file locations and bumping up the versions on the actions works.

ssolson commented 2 months ago

@akeeste with the tests now working could you give this a final review/ approval (assuming all tests pass in ~4 hours)?

My goal is to get this into develop today/ this weekend so I can then have these tests pass on #307 over the weekend.