search

MHKiT-Software / MHKiT-Python

MHKiT-Python provides the marine renewable energy (MRE) community tools for data processing, visualization, quality control, resource assessment, and device performance.
https://mhkit-software.github.io/MHKiT/
BSD 3-Clause "New" or "Revised" License
47 stars 45 forks source link

Coords #312

Open browniea opened 2 months ago

browniea commented 2 months ago

Added file named for D3D mapformat=4

Added function _get_cords_to_layers

browniea commented 2 months ago

Planning to reformate similar to Wave moduel line 670

ssolson commented 1 month ago

Hey @browniea apologies for messing this PR up. This should be easier going forward but there were some inconsistencies in how PR merged strategies were applied by the final merge author which made this messier. I perhaps should have just accepted the mess but instead decided to squash into master. My preferred strategy going forward is to squash PRs to develop and merge by ort into master.

To ensure master and develop are even I did a force rebase on origin develop.

That said can you either rebase or resubmit this PR? The official approach is to:

git checkout develop
git fetch origin
git reset --hard origin/develop

git checkout feature-branch
git rebase develop
git push user-fork feature-branch --force

That said rebasing may be extremely painful and it might be easier to just start from the new develop and remake the changes. Apologies for the trouble on this.

ssolson commented 1 month ago

Hey @browniea I was playing around with the D3D files today and what we want to determine the different key variables is the Conventions.

filename = "./tanana50_map.nc"
dflow_map = xr.open_dataset(filename)
dflow_map.Conventions

'UGRID-0.9'

A newer file I was working with from chris returns `'CF-1.8 UGRID-1.0 Deltares-0.10'

Using this keyword should direct the variable names we use when accessing data.